use logger.LogOnce to reduce printing disconnection logs (#15408)

fixes #15334

- re-use net/url parsed value for http.Request{}
- remove gosimple, structcheck and unusued due to https://github.com/golangci/golangci-lint/issues/2649
- unwrapErrs upto leafErr to ensure that we store exactly the correct errors

docs/site-replication/run-multi-site-ldap.sh

@@ -3,6 +3,14 @@
 # shellcheck disable=SC2120
 exit_1() {
     cleanup
+
+    echo "minio1 ============"
+    cat /tmp/minio1_1.log
+    echo "minio2 ============"
+    cat /tmp/minio2_1.log
+    echo "minio3 ============"
+    cat /tmp/minio3_1.log
+
     exit 1
 }
 
@@ -38,7 +46,7 @@ export MINIO_IDENTITY_LDAP_GROUP_SEARCH_FILTER="(&(objectclass=groupOfNames)(mem
 
 if [ ! -f ./mc ]; then
     wget -O mc https://dl.minio.io/client/mc/release/linux-amd64/mc \
-        && chmod +x mc
+	&& chmod +x mc
 fi
 
 minio server --config-dir /tmp/minio-ldap --address ":9001" /tmp/minio-ldap-idp1/{1...4} >/tmp/minio1_1.log 2>&1 &
@@ -268,7 +276,8 @@ kill -9 ${site1_pid}
 
 # Restart minio1 instance
 minio server --config-dir /tmp/minio-ldap --address ":9001" /tmp/minio-ldap-idp1/{1...4} >/tmp/minio1_1.log 2>&1 &
-sleep 15
+sleep 30
+
 # Test whether most recent tag update on minio2 is replicated to minio1
 val=$(./mc tag list minio1/newbucket --json | jq -r .tagset | jq -r .key )
 if [ "${val}" != "val2" ]; then
@@ -279,7 +288,7 @@ fi
 # Test if bucket created/deleted when minio1 is down healed
 diff -q <(./mc ls minio1)  <(./mc ls minio2) 1>/dev/null
 if  [ $? -ne 0 ]; then
-    echo "expected `bucket2` delete and `newbucket2` creation to have replicated, exiting..."
+    echo "expected 'bucket2' delete and 'newbucket2' creation to have replicated, exiting..."
     exit_1;
 fi
 

docs/site-replication/run-multi-site-minio-idp.sh

@@ -3,6 +3,14 @@
 # shellcheck disable=SC2120
 exit_1() {
     cleanup
+
+    echo "minio1 ============"
+    cat /tmp/minio1_1.log
+    echo "minio2 ============"
+    cat /tmp/minio2_1.log
+    echo "minio3 ============"
+    cat /tmp/minio3_1.log
+
     exit 1
 }
 
@@ -30,7 +38,7 @@ export MINIO_KMS_SECRET_KEY=my-minio-key:OSMM+vkKUTCvQs9YL/CVMIMt43HFhkUpqJxTmGl
 
 if [ ! -f ./mc ]; then
     wget -O mc https://dl.minio.io/client/mc/release/linux-amd64/mc \
-        && chmod +x mc
+	&& chmod +x mc
 fi
 
 minio server --config-dir /tmp/minio-internal --address ":9001" /tmp/minio-internal-idp1/{1...4} >/tmp/minio1_1.log 2>&1 &
@@ -327,7 +335,7 @@ kill -9 ${site1_pid}
 ./mc rb minio2/bucket2
 # Restart minio1 instance
 minio server --config-dir /tmp/minio-internal --address ":9001" /tmp/minio-internal-idp1/{1...4} >/tmp/minio1_1.log 2>&1 &
-sleep 15
+sleep 30
 
 # Test whether most recent tag update on minio2 is replicated to minio1
 val=$(./mc tag list minio1/newbucket --json | jq -r .tagset | jq -r .key )
@@ -335,9 +343,10 @@ if [ "${val}" != "val2" ]; then
     echo "expected bucket tag to have replicated, exiting..."
     exit_1;
 fi
+
 # Test if bucket created/deleted when minio1 is down healed
 diff -q <(./mc ls minio1)  <(./mc ls minio2) 1>/dev/null
 if  [ $? -ne 0 ]; then
-    echo "expected `bucket2` delete and `newbucket2` creation to have replicated, exiting..."
+    echo "expected 'bucket2' delete and 'newbucket2' creation to have replicated, exiting..."
     exit_1;
-fi
+fi

docs/site-replication/run-multi-site-oidc.sh

@@ -3,6 +3,14 @@
 # shellcheck disable=SC2120
 exit_1() {
     cleanup
+
+    echo "minio1 ============"
+    cat /tmp/minio1_1.log
+    echo "minio2 ============"
+    cat /tmp/minio2_1.log
+    echo "minio3 ============"
+    cat /tmp/minio3_1.log
+
     exit 1
 }
 
@@ -46,7 +54,7 @@ site3_pid=$!
 
 if [ ! -f ./mc ]; then
     wget -O mc https://dl.minio.io/client/mc/release/linux-amd64/mc \
-        && chmod +x mc
+	&& chmod +x mc
 fi
 
 sleep 10
@@ -252,7 +260,8 @@ kill -9 ${site1_pid}
 
 # Restart minio1 instance
 minio server --address ":9001" --console-address ":10000" /tmp/minio1/{1...4} >/tmp/minio1_1.log 2>&1 &
-sleep 15
+sleep 30
+
 # Test whether most recent tag update on minio2 is replicated to minio1
 val=$(./mc tag list minio1/newbucket --json | jq -r .tagset | jq -r .key )
 if [ "${val}" != "val2" ]; then
@@ -263,6 +272,6 @@ fi
 # Test if bucket created/deleted when minio1 is down healed
 diff -q <(./mc ls minio1)  <(./mc ls minio2) 1>/dev/null
 if  [ $? -ne 0 ]; then
-    echo "expected `bucket2` delete and `newbucket2` creation to have replicated, exiting..."
+    echo "expected 'bucket2' delete and 'newbucket2' creation to have replicated, exiting..."
     exit_1;
 fi