MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-02-28 05:49:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: CopyObject with REPLACE directive deletes existing tags (#9478)

Browse Source 
Fixes #9477
This commit is contained in:
P R 2020-04-28 21:56:37 -07:00 committed by GitHub
parent ab77b216d1
commit 5dd9cf4398
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/object-handlers.go
View File

@ -656,9 +656,9 @@ func getCpObjTagsFromHeader(ctx context.Context, r *http.Request, tags string) (
if tags := r.Header.Get(xhttp.AmzObjectTagging); tags != "" { if tags := r.Header.Get(xhttp.AmzObjectTagging); tags != "" {
return extractTags(ctx, tags) return extractTags(ctx, tags)
} }
// Copy is default behavior if x-amz-tagging-directive is set, but x-amz-tagging is // If x-amz-tagging-directive is explicitly set to replace and x-amz-tagging is not set.
// is not set // The S3 behavior is to unset the tags.
return tags, nil return "", nil
} }
// Copy is default behavior if x-amz-tagging-directive is not set. // Copy is default behavior if x-amz-tagging-directive is not set.