Order all keys in config (#8541)

New changes

- return default values when sub-sys is
  not configured.
- state is hidden parameter now
- remove worm mode to be saved in config

cmd/config/identity/openid/help.go

@@ -21,11 +21,6 @@ import "github.com/minio/minio/cmd/config"
 // Help template for OpenID identity feature.
 var (
 	Help = config.HelpKVS{
-		config.HelpKV{
-			Key:         config.State,
-			Description: "Indicates if OpenID identity is enabled or not",
-			Type:        "on|off",
-		},
 		config.HelpKV{
 			Key:         ConfigURL,
 			Description: `OpenID discovery documented endpoint. eg: "https://accounts.google.com/.well-known/openid-configuration"`,

cmd/config/identity/openid/jwt.go

@@ -258,11 +258,22 @@ func parseDiscoveryDoc(u *xnet.URL, transport *http.Transport, closeRespFn func(
 // DefaultKVS - default config for OpenID config
 var (
 	DefaultKVS = config.KVS{
-		config.State:   config.StateOff,
-		config.Comment: "This is a default OpenID configuration",
-		JwksURL:        "",
-		ConfigURL:      "",
-		ClaimPrefix:    "",
+		config.KV{
+			Key:   config.State,
+			Value: config.StateOff,
+		},
+		config.KV{
+			Key:   JwksURL,
+			Value: "",
+		},
+		config.KV{
+			Key:   ConfigURL,
+			Value: "",
+		},
+		config.KV{
+			Key:   ClaimPrefix,
+			Value: "",
+		},
 	}
 )
 

cmd/config/identity/openid/legacy.go

@@ -30,9 +30,21 @@ func SetIdentityOpenID(s config.Config, cfg Config) {
 		return
 	}
 	s[config.IdentityOpenIDSubSys][config.Default] = config.KVS{
-		config.State: config.StateOn,
-		JwksURL:      cfg.JWKS.URL.String(),
-		ConfigURL:    "",
-		ClaimPrefix:  "",
+		config.KV{
+			Key:   config.State,
+			Value: config.StateOn,
+		},
+		config.KV{
+			Key:   JwksURL,
+			Value: cfg.JWKS.URL.String(),
+		},
+		config.KV{
+			Key:   ConfigURL,
+			Value: "",
+		},
+		config.KV{
+			Key:   ClaimPrefix,
+			Value: "",
+		},
 	}
 }