MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-24 22:25:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: properly send group unset policy (#12694)

Browse Source 
In distributed setups `mc admin group unset`
was not correctly working due to incorrect
handling of query parameters between peers.
This commit is contained in:
Harshavardhana 2021-07-13 09:32:35 -07:00 committed by GitHub
parent e25ae1c01f
commit 559d075627
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/peer-rest-server.go
View File

@ -129,8 +129,8 @@ func (s *peerRESTServer) LoadPolicyMappingHandler(w http.ResponseWriter, r *http
s.writeErrorResponse(w, errors.New("user-or-group is missing")) s.writeErrorResponse(w, errors.New("user-or-group is missing"))
return return
} }
_, isGroup := vars[peerRESTIsGroup]
_, isGroup := r.URL.Query()[peerRESTIsGroup]
if err := globalIAMSys.LoadPolicyMapping(objAPI, userOrGroup, isGroup); err != nil { if err := globalIAMSys.LoadPolicyMapping(objAPI, userOrGroup, isGroup); err != nil {
s.writeErrorResponse(w, err) s.writeErrorResponse(w, err)
return return
@ -384,7 +384,6 @@ func (s *peerRESTServer) NetInfoHandler(w http.ResponseWriter, r *http.Request)
} }
if n != r.ContentLength { if n != r.ContentLength {
err := fmt.Errorf("Subnet health: short read: expected %d found %d", r.ContentLength, n) err := fmt.Errorf("Subnet health: short read: expected %d found %d", r.ContentLength, n)
logger.LogIf(ctx, err) logger.LogIf(ctx, err)
w.Header().Set("FinalStatus", err.Error()) w.Header().Set("FinalStatus", err.Error())
return return