MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-25 22:55:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

Report healthy status for initial 120s, then switch to healthcheck (#4799)

Browse Source 
Swarm routes traffic only to containers that report healthy status,
while Minio in distributed mode needs to talk to other peers before
it can respond to healthcheck probe. As the Minio containers are not
able to talk to each other, distributed Minio is not getting started
on Docker Swarm.

With this PR, Minio Healthcheck report healthy status for initial
120s enough for distributed Minio to start. After that normal
Healthcheck resumes. Also changed the healthcheck method name
in accordance with Google shell styleguide.

Fixes: https://github.com/minio/minio/issues/4761
This commit is contained in:
Nitish Tiwari 2017-08-13 07:56:35 +05:30 committed by Dee Koder
parent d864e00e24
commit 53f84d6084
1 changed files with 30 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
buildscripts/healthcheck.sh
View File

@ -19,25 +19,40 @@ _init () {
scheme="http://" scheme="http://"
address="127.0.0.1:9000" address="127.0.0.1:9000"
resource="/minio/index.html" resource="/minio/index.html"
start=$(stat -c "%Y" /proc/1)
} }
HealthCheckMain () { healthcheck_main () {
# In distributed environment like Swarm, traffic is routed
# to a container only when it reports a `healthy` status. So, we exit
# with 0 to ensure healthy status till distributed Minio starts (120s).
#
# Refer: https://github.com/moby/moby/pull/28938#issuecomment-301753272
if [ $(( $(date +%s) - start )) -lt 120 ]; then
exit 0
else
# Get the http response code # Get the http response code
http_response=$(curl -s -k -o /dev/null -I -w "%{http_code}" ${scheme}${address}${resource}) http_response=$(curl -s -k -o /dev/null -I -w "%{http_code}" \
${scheme}${address}${resource})
# Get the http response body # Get the http response body
http_response_body=$(curl -k -s ${scheme}${address}${resource}) http_response_body=$(curl -k -s ${scheme}${address}${resource})
# server returns response 403 and body "SSL required" if non-TLS connection is attempted on a TLS-configured server. # server returns response 403 and body "SSL required" if non-TLS
# change the scheme and try again # connection is attempted on a TLS-configured server. Change
if [ "$http_response" = "403" ] && [ "$http_response_body" = "SSL required" ]; then # the scheme and try again
if [ "$http_response" = "403" ] && \
[ "$http_response_body" = "SSL required" ]; then
scheme="https://" scheme="https://"
http_response=$(curl -s -k -o /dev/null -I -w "%{http_code}" ${scheme}${address}${resource}) http_response=$(curl -s -k -o /dev/null -I -w "%{http_code}" \
${scheme}${address}${resource})
fi fi
# If http_repsonse is 200 - server is up. # If http_repsonse is 200 - server is up. When MINIO_BROWSER is
# When MINIO_BROWSER is set to off, curl responds with 404. We assume that the the server is up # set to off, curl responds with 404. We assume that the server
# is up
[ "$http_response" = "200" ] || [ "$http_response" = "404" ] [ "$http_response" = "200" ] || [ "$http_response" = "404" ]
fi
} }
_init && HealthCheckMain _init && healthcheck_main