MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-10 05:59:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

utils: reduceErrs returns and validates quorum errors. (#3300)

Browse Source 
This is needed as explained by @krisis

Lets say we have following errors.

```
[]error{nil, errFileNotFound, errDiskAccessDenied, errDiskAccesDenied}
```

Since the last two errors are filtered, the maximum is nil,
depending on map order.

Let's say we get nil from reduceErr. Clearly at this point
we don't have quorum nodes agreeing about the data and since
GetObject only requires N/2 (Read quorum) and isDiskQuorum
would have returned true. This is problematic and can lead to
undersiable consequences.

Fixes #3298
This commit is contained in:
Harshavardhana
2016-11-21 01:47:26 -08:00
committed by GitHub
parent 066f64d34a
commit 5197649081
10 changed files with 75 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/xl-v1-object.go
View File

@@ -79,7 +79,7 @@ func (xl xlObjects) GetObject(bucket, object string, startOffset int64, length i
return traceError(InsufficientReadQuorum{}, errs...)
}
if reducedErr := reduceErrs(errs, objectOpIgnoredErrs); reducedErr != nil {
if reducedErr := reduceReadQuorumErrs(errs, objectOpIgnoredErrs, xl.readQuorum); reducedErr != nil {
return toObjectErr(reducedErr, bucket, object)
}
@@ -339,8 +339,7 @@ func rename(disks []StorageAPI, srcBucket, srcEntry, dstBucket, dstEntry string,
undoRename(disks, srcBucket, srcEntry, dstBucket, dstEntry, isPart, errs)
return traceError(errXLWriteQuorum)
}
// Return on first error, also undo any partially successful rename operations.
return reduceErrs(errs, objectOpIgnoredErrs)
return reduceWriteQuorumErrs(errs, objectOpIgnoredErrs, quorum)
}
// renamePart - renames a part of the source object to the destination