MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-08 21:24:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

Return cached online/offline status for audit/http loggers (#18083)

Browse Source 
To avoid having delays in prometheus scrape and in 'mc admin info' command.
This commit is contained in:
Anis Eleuch
2023-09-21 16:58:24 -07:00
committed by GitHub
parent 373d48c8a3
commit 4eeb48f8e0
2 changed files with 32 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
internal/logger/target/http/http.go
View File

@@ -127,8 +127,13 @@ func (h *Target) String() string {
return h.config.Name
}
// IsOnline returns true if the target is reachable.
// IsOnline returns true if the target is reachable using a cached value
func (h *Target) IsOnline(ctx context.Context) bool {
return atomic.LoadInt32(&h.status) == statusOnline
}
// ping returns true if the target is reachable.
func (h *Target) ping(ctx context.Context) bool {
if err := h.send(ctx, []byte(`{}`), webhookCallTimeout); err != nil {
return !xnet.IsNetworkOrHostDown(err, false) && !xnet.IsConnRefusedErr(err)
}
@@ -179,7 +184,7 @@ func (h *Target) init(ctx context.Context) (err error) {
return errors.New("target is closed")
}
if !h.IsOnline(ctx) {
if !h.ping(ctx) {
// Start a goroutine that will continue to check if we can reach
h.revive.Do(func() {
go func() {
@@ -191,7 +196,7 @@ func (h *Target) init(ctx context.Context) (err error) {
if atomic.LoadInt32(&h.status) != statusOffline {
return
}
if h.IsOnline(ctx) {
if h.ping(ctx) {
// We are online.
if atomic.CompareAndSwapInt32(&h.status, statusOffline, statusOnline) {
h.workerStartMu.Lock()
@@ -219,6 +224,14 @@ func (h *Target) init(ctx context.Context) (err error) {
}
func (h *Target) send(ctx context.Context, payload []byte, timeout time.Duration) (err error) {
defer func() {
if err != nil {
atomic.StoreInt32(&h.status, statusOffline)
} else {
atomic.StoreInt32(&h.status, statusOnline)
}
}()
ctx, cancel := context.WithTimeout(ctx, timeout)
defer cancel()
req, err := http.NewRequestWithContext(ctx, http.MethodPost,