MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-22 18:47:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

allow lifecycle rules with overlapping prefixes (#10053)

Browse Source
This commit is contained in:
findmyname666
2020-07-16 16:39:41 +02:00
committed by GitHub
parent 7b14e9b660
commit 48aebf2d9d
2 changed files with 47 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/bucket/lifecycle/lifecycle.go
View File

@@ -24,9 +24,9 @@ import (
)
var (
errLifecycleTooManyRules = Errorf("Lifecycle configuration allows a maximum of 1000 rules")
errLifecycleNoRule = Errorf("Lifecycle configuration should have at least one rule")
errLifecycleOverlappingPrefix = Errorf("Lifecycle configuration has rules with overlapping prefix")
errLifecycleTooManyRules = Errorf("Lifecycle configuration allows a maximum of 1000 rules")
errLifecycleNoRule = Errorf("Lifecycle configuration should have at least one rule")
errLifecycleDuplicateID = Errorf("Lifecycle configuration has rule with the same ID. Rule ID must be unique.")
)
// Action represents a delete action or other transition
@@ -115,17 +115,15 @@ func (lc Lifecycle) Validate() error {
return err
}
}
// Compare every rule's prefix with every other rule's prefix
// Make sure Rule ID is unique
for i := range lc.Rules {
if i == len(lc.Rules)-1 {
break
}
// N B Empty prefixes overlap with all prefixes
otherRules := lc.Rules[i+1:]
for _, otherRule := range otherRules {
if strings.HasPrefix(lc.Rules[i].Prefix(), otherRule.Prefix()) ||
strings.HasPrefix(otherRule.Prefix(), lc.Rules[i].Prefix()) {
return errLifecycleOverlappingPrefix
if lc.Rules[i].ID == otherRule.ID {
return errLifecycleDuplicateID
}
}
}