mirror of
https://github.com/minio/minio.git
synced 2025-11-25 12:06:10 -05:00
Enhance the event store interface to support channeling (#7343)
- Avoids code duplication across the other targets. By having a centralized function call. - Reduce the room for race.
This commit is contained in:
committed by
Nitish Tiwari
parent
ddb0d646aa
commit
47ca411163
@@ -18,20 +18,106 @@ package target
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/minio/minio/pkg/event"
|
||||
)
|
||||
|
||||
// ErrLimitExceeded error is sent when the maximum limit is reached.
|
||||
var ErrLimitExceeded = errors.New("[Store] The maximum limit reached")
|
||||
const retryInterval = 3 * time.Second
|
||||
|
||||
// ErrNoSuchKey error is sent in Get when the key is not found.
|
||||
var ErrNoSuchKey = errors.New("[Store] No such key found")
|
||||
// errNotConnected - indicates that the target connection is not active.
|
||||
var errNotConnected = errors.New("not connected to target server/service")
|
||||
|
||||
// errLimitExceeded error is sent when the maximum limit is reached.
|
||||
var errLimitExceeded = errors.New("the maximum store limit reached")
|
||||
|
||||
// errNoSuchKey error is sent in Get when the key is not found.
|
||||
var errNoSuchKey = errors.New("no such key found in store")
|
||||
|
||||
// Store - To persist the events.
|
||||
type Store interface {
|
||||
Put(event event.Event) error
|
||||
Get(key string) (event.Event, error)
|
||||
ListAll() []string
|
||||
Del(key string)
|
||||
ListN(n int) []string
|
||||
Del(key string) error
|
||||
Open() error
|
||||
}
|
||||
|
||||
// replayEvents - Reads the events from the store and replays.
|
||||
func replayEvents(store Store, doneCh <-chan struct{}) <-chan string {
|
||||
var names []string
|
||||
eventKeyCh := make(chan string)
|
||||
|
||||
go func() {
|
||||
retryTimer := time.NewTimer(retryInterval)
|
||||
defer retryTimer.Stop()
|
||||
defer close(eventKeyCh)
|
||||
for {
|
||||
names = store.ListN(100)
|
||||
for _, name := range names {
|
||||
select {
|
||||
case eventKeyCh <- strings.TrimSuffix(name, eventExt):
|
||||
// Get next key.
|
||||
case <-doneCh:
|
||||
return
|
||||
}
|
||||
}
|
||||
|
||||
if len(names) < 2 {
|
||||
retryTimer.Reset(retryInterval)
|
||||
select {
|
||||
case <-retryTimer.C:
|
||||
case <-doneCh:
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
}()
|
||||
|
||||
return eventKeyCh
|
||||
}
|
||||
|
||||
// sendEvents - Reads events from the store and re-plays.
|
||||
func sendEvents(target event.Target, eventKeyCh <-chan string, doneCh <-chan struct{}) {
|
||||
retryTimer := time.NewTimer(retryInterval)
|
||||
defer retryTimer.Stop()
|
||||
|
||||
send := func(eventKey string) bool {
|
||||
for {
|
||||
err := target.Send(eventKey)
|
||||
if err == nil {
|
||||
break
|
||||
}
|
||||
|
||||
if err != errNotConnected {
|
||||
panic(fmt.Errorf("target.Send() failed with '%v'", err))
|
||||
}
|
||||
|
||||
retryTimer.Reset(retryInterval)
|
||||
select {
|
||||
case <-retryTimer.C:
|
||||
case <-doneCh:
|
||||
return false
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
for {
|
||||
select {
|
||||
case eventKey, ok := <-eventKeyCh:
|
||||
if !ok {
|
||||
// closed channel.
|
||||
return
|
||||
}
|
||||
|
||||
if !send(eventKey) {
|
||||
return
|
||||
}
|
||||
case <-doneCh:
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user