MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-25 22:55:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

posix: parseDirents() should follow symlink and get values. (#1631)

Browse Source 
Previously parseDirents() ignores symbolic links.  This patch fixes
the issue by following the symlink using os.Stat().

Fixes #1545
This commit is contained in:
Bala FA 2016-05-14 00:09:48 +05:30 committed by Harshavardhana
parent 9e45d138cc
commit 43539a0c86
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
posix-list-dir-nix.go
View File

@ -79,7 +79,9 @@ func parseDirents(dirPath string, buf []byte) (entries []string, err error) {
entries = append(entries, name+slashSeparator) entries = append(entries, name+slashSeparator)
case syscall.DT_REG: case syscall.DT_REG:
entries = append(entries, name) entries = append(entries, name)
case syscall.DT_UNKNOWN: case syscall.DT_LNK, syscall.DT_UNKNOWN:
// If its symbolic link, follow the link using os.Stat()
// On Linux XFS does not implement d_type for on disk // On Linux XFS does not implement d_type for on disk
// format << v5. Fall back to Stat(). // format << v5. Fall back to Stat().
var fi os.FileInfo var fi os.FileInfo
@ -101,7 +103,6 @@ func parseDirents(dirPath string, buf []byte) (entries []string, err error) {
} }
default: default:
// Skip entries which are not file or directory. // Skip entries which are not file or directory.
// FIXME: should we handle symlinks?
continue continue
} }
} }