From 41ec038523007d5046ac71a5c8c083ccef6b7a4f Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Thu, 11 Apr 2024 14:22:15 -0700 Subject: [PATCH] remove permission denied error for being drive error (#19478) --- cmd/metrics-v2.go | 2 +- cmd/metrics-v3-system-drive.go | 2 +- cmd/xl-storage-disk-id-check.go | 5 +--- docs/metrics/v3.md | 48 ++++++++++++++++----------------- 4 files changed, 27 insertions(+), 30 deletions(-) diff --git a/cmd/metrics-v2.go b/cmd/metrics-v2.go index 874fbec53..42147786f 100644 --- a/cmd/metrics-v2.go +++ b/cmd/metrics-v2.go @@ -546,7 +546,7 @@ func getNodeDriveAvailabilityErrorsMD() MetricDescription { Namespace: nodeMetricNamespace, Subsystem: driveSubsystem, Name: "errors_availability", - Help: "Total number of drive I/O errors, permission denied and timeouts since server start", + Help: "Total number of drive I/O errors, timeouts since server start", Type: counterMetric, } } diff --git a/cmd/metrics-v3-system-drive.go b/cmd/metrics-v3-system-drive.go index b231b1787..e1c9bd211 100644 --- a/cmd/metrics-v3-system-drive.go +++ b/cmd/metrics-v3-system-drive.go @@ -83,7 +83,7 @@ var ( driveTimeoutErrorsMD = NewCounterMD(driveTimeoutErrorsTotal, "Total timeout errors on a drive", allDriveLabels...) driveAvailabilityErrorsMD = NewCounterMD(driveAvailabilityErrorsTotal, - "Total availability errors (I/O errors, permission denied and timeouts) on a drive", + "Total availability errors (I/O errors, timeouts) on a drive", allDriveLabels...) driveWaitingIOMD = NewGaugeMD(driveWaitingIO, "Total waiting I/O operations on a drive", allDriveLabels...) diff --git a/cmd/xl-storage-disk-id-check.go b/cmd/xl-storage-disk-id-check.go index 4ded5179b..58a41ef0b 100644 --- a/cmd/xl-storage-disk-id-check.go +++ b/cmd/xl-storage-disk-id-check.go @@ -79,7 +79,7 @@ const ( type xlStorageDiskIDCheck struct { totalWrites atomic.Uint64 totalDeletes atomic.Uint64 - totalErrsAvailability atomic.Uint64 // Captures all data availability errors such as permission denied, faulty disk and timeout errors. + totalErrsAvailability atomic.Uint64 // Captures all data availability errors such as faulty disk, timeout errors. totalErrsTimeout atomic.Uint64 // Captures all timeout only errors // apiCalls should be placed first so alignment is guaranteed for atomic operations. @@ -740,9 +740,6 @@ func (p *xlStorageDiskIDCheck) updateStorageMetrics(s storageMetric, paths ...st atomic.AddUint64(&p.apiCalls[s], 1) if IsErr(err, []error{ - errVolumeAccessDenied, - errFileAccessDenied, - errDiskAccessDenied, errFaultyDisk, errFaultyRemoteDisk, context.DeadlineExceeded, diff --git a/docs/metrics/v3.md b/docs/metrics/v3.md index aebd6e32d..185b9c4ef 100644 --- a/docs/metrics/v3.md +++ b/docs/metrics/v3.md @@ -100,30 +100,30 @@ The standard metrics groups for ProcessCollector and GoCollector are not shown b ### `/system/drive` -| Name | Type | Help | Labels | -|------------------------------------------------|-----------|-----------------------------------------------------------------------------------|-----------------------------------------------------| -| `minio_system_drive_used_bytes` | `gauge` | Total storage used on a drive in bytes | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_free_bytes` | `gauge` | Total storage free on a drive in bytes | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_total_bytes` | `gauge` | Total storage available on a drive in bytes | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_used_inodes` | `gauge` | Total used inodes on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_free_inodes` | `gauge` | Total free inodes on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_total_inodes` | `gauge` | Total inodes available on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_timeout_errors_total` | `counter` | Total timeout errors on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_availability_errors_total` | `counter` | Total availability errors (I/O errors, permission denied and timeouts) on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_waiting_io` | `gauge` | Total waiting I/O operations on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_api_latency_micros` | `gauge` | Average last minute latency in µs for drive API storage operations | `drive,api,set_index,drive_index,pool_index,server` | -| `minio_system_drive_offline_count` | `gauge` | Count of offline drives | `pool_index,server` | -| `minio_system_drive_online_count` | `gauge` | Count of online drives | `pool_index,server` | -| `minio_system_drive_count` | `gauge` | Count of all drives | `pool_index,server` | -| `minio_system_drive_healing` | `gauge` | Is it healing? | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_online` | `gauge` | Is it online? | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_reads_per_sec` | `gauge` | Reads per second on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_reads_kb_per_sec` | `gauge` | Kilobytes read per second on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_reads_await` | `gauge` | Average time for read requests served on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_writes_per_sec` | `gauge` | Writes per second on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_writes_kb_per_sec` | `gauge` | Kilobytes written per second on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_writes_await` | `gauge` | Average time for write requests served on a drive | `drive,set_index,drive_index,pool_index,server` | -| `minio_system_drive_perc_util` | `gauge` | Percentage of time the disk was busy | `drive,set_index,drive_index,pool_index,server` | +| Name | Type | Help | Labels | +|------------------------------------------------|-----------|--------------------------------------------------------------------|-----------------------------------------------------| +| `minio_system_drive_used_bytes` | `gauge` | Total storage used on a drive in bytes | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_free_bytes` | `gauge` | Total storage free on a drive in bytes | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_total_bytes` | `gauge` | Total storage available on a drive in bytes | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_used_inodes` | `gauge` | Total used inodes on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_free_inodes` | `gauge` | Total free inodes on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_total_inodes` | `gauge` | Total inodes available on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_timeout_errors_total` | `counter` | Total timeout errors on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_availability_errors_total` | `counter` | Total availability errors (I/O errors, timeouts) on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_waiting_io` | `gauge` | Total waiting I/O operations on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_api_latency_micros` | `gauge` | Average last minute latency in µs for drive API storage operations | `drive,api,set_index,drive_index,pool_index,server` | +| `minio_system_drive_offline_count` | `gauge` | Count of offline drives | `pool_index,server` | +| `minio_system_drive_online_count` | `gauge` | Count of online drives | `pool_index,server` | +| `minio_system_drive_count` | `gauge` | Count of all drives | `pool_index,server` | +| `minio_system_drive_healing` | `gauge` | Is it healing? | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_online` | `gauge` | Is it online? | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_reads_per_sec` | `gauge` | Reads per second on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_reads_kb_per_sec` | `gauge` | Kilobytes read per second on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_reads_await` | `gauge` | Average time for read requests served on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_writes_per_sec` | `gauge` | Writes per second on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_writes_kb_per_sec` | `gauge` | Kilobytes written per second on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_writes_await` | `gauge` | Average time for write requests served on a drive | `drive,set_index,drive_index,pool_index,server` | +| `minio_system_drive_perc_util` | `gauge` | Percentage of time the disk was busy | `drive,set_index,drive_index,pool_index,server` | ### `/system/network/internode`