MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-10 05:59:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: apply pre-conditions first on object metadata (#12545)

Browse Source 
This change in error flow complies with AWS S3 behavior
for applications depending on specific error conditions.

fixes #12543
This commit is contained in:
Harshavardhana
2021-06-24 09:44:00 -07:00
committed by GitHub
parent 9bf1ac0bb6
commit 41caf89cf4
9 changed files with 74 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/gateway/s3/gateway-s3-sse.go
View File

@@ -345,7 +345,7 @@ func (l *s3EncObjects) GetObjectNInfo(ctx context.Context, bucket, object string
// Setup cleanup function to cause the above go-routine to
// exit in case of partial read
pipeCloser := func() { pr.Close() }
return fn(pr, h, o.CheckPrecondFn, pipeCloser)
return fn(pr, h, pipeCloser)
}
// GetObjectInfo reads object info and replies back ObjectInfo

2
cmd/gateway/s3/gateway-s3.go
View File

@@ -404,7 +404,7 @@ func (l *s3Objects) GetObjectNInfo(ctx context.Context, bucket, object string, r
// Setup cleanup function to cause the above go-routine to
// exit in case of partial read
pipeCloser := func() { pr.Close() }
return fn(pr, h, opts.CheckPrecondFn, pipeCloser)
return fn(pr, h, pipeCloser)
}
// GetObject reads an object from S3. Supports additional