MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-23 12:43:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

api: MakeBucket should set proper bucket location. (#1948)

Browse Source 
Fixes #1942
This commit is contained in:
Harshavardhana 2016-06-20 23:25:18 -07:00 committed by GitHub
parent ad779a8ba4
commit 409b4ddecb
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api-response.go
View File

@ -19,6 +19,7 @@ package main
import ( import (
"encoding/xml" "encoding/xml"
"net/http" "net/http"
"path"
"time" "time"
) )
@ -255,7 +256,7 @@ type DeleteObjectsResponse struct {
// getLocation get URL location. // getLocation get URL location.
func getLocation(r *http.Request) string { func getLocation(r *http.Request) string {
return r.URL.Path return path.Clean(r.URL.Path) // Clean any trailing slashes.
} }
// getObjectLocation gets the relative URL for an object // getObjectLocation gets the relative URL for an object

13
server_xl_test.go
View File

@ -1513,6 +1513,19 @@ func (s *MyAPIXLSuite) TestBucketMultipartList(c *C) {
c.Assert(newResponse3.Bucket, Equals, "bucketmultipartlist") c.Assert(newResponse3.Bucket, Equals, "bucketmultipartlist")
} }
// TestMakeBucketLocation - tests make bucket location header response.
func (s *MyAPIXLSuite) TestMakeBucketLocation(c *C) {
request, err := s.newRequest("PUT", testAPIXLServer.URL+"/make-bucket-location", 0, nil)
c.Assert(err, IsNil)
client := http.Client{}
response, err := client.Do(request)
c.Assert(err, IsNil)
c.Assert(response.StatusCode, Equals, 200)
// Validate location header value equals proper bucket name.
c.Assert(response.Header.Get("Location"), Equals, "/make-bucket-location")
}
func (s *MyAPIXLSuite) TestValidateObjectMultipartUploadID(c *C) { func (s *MyAPIXLSuite) TestValidateObjectMultipartUploadID(c *C) {
request, err := s.newRequest("PUT", testAPIXLServer.URL+"/objectmultipartlist-uploadid", 0, nil) request, err := s.newRequest("PUT", testAPIXLServer.URL+"/objectmultipartlist-uploadid", 0, nil)
c.Assert(err, IsNil) c.Assert(err, IsNil)