MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-03-03 07:10:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Treat 0.0.0.0 as local address in --address flag (#4386)

Browse Source
This commit is contained in:
Krishnan Parthasarathi 2017-05-24 00:37:39 +05:30 committed by Harshavardhana
parent 28c26a9e59
commit 3c5db69ffd
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/net.go
View File

@ -319,7 +319,10 @@ func CheckLocalServerAddr(serverAddr string) error {
return fmt.Errorf("port number must be between 1 to 65535") return fmt.Errorf("port number must be between 1 to 65535")
} }
if host != "" { // 0.0.0.0 is a wildcard address and refers to local network
// addresses. I.e, 0.0.0.0:9000 like ":9000" refers to port
// 9000 on localhost.
if host != "" && host != net.IPv4zero.String() {
isLocalHost, err := isLocalHost(host) isLocalHost, err := isLocalHost(host)
if err != nil { if err != nil {
return err return err

1
cmd/net_test.go
View File

@ -221,6 +221,7 @@ func TestCheckLocalServerAddr(t *testing.T) {
}{ }{
{":54321", nil}, {":54321", nil},
{"localhost:54321", nil}, {"localhost:54321", nil},
{"0.0.0.0:9000", nil},
{"", fmt.Errorf("missing port in address")}, {"", fmt.Errorf("missing port in address")},
{"localhost", fmt.Errorf("missing port in address localhost")}, {"localhost", fmt.Errorf("missing port in address localhost")},
{"example.org:54321", fmt.Errorf("host in server address should be this server")}, {"example.org:54321", fmt.Errorf("host in server address should be this server")},