MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-09 13:39:46 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: SQL select to honor limits properly for array queries (#13568)

Browse Source 
added tests to cover the scenarios as well.
This commit is contained in:
Harshavardhana
2021-11-02 19:14:46 -07:00
committed by GitHub
parent 58934e5881
commit 34680c5ccf
4 changed files with 83 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
internal/s3select/sql/parser_test.go
View File

@@ -332,6 +332,7 @@ func TestFromClauseJSONPath(t *testing.T) {
"select * from s3object[*].books[*].name as s",
"select * from s3object s where name > 2",
"select * from s3object[*].name as s where name > 2",
"select * from s3object[*].books[*] limit 1",
}
for i, tc := range cases {
err := p.ParseString(tc, &s)

9
internal/s3select/sql/statement.go
View File

@@ -302,9 +302,8 @@ func (e *SelectStatement) Eval(input, output Record) (Record, error) {
// .. WHERE ..`
// Update count of records output.
if e.limitValue > -1 {
e.outputCount++
}
e.outputCount++
return input.Clone(output), nil
}
@@ -328,9 +327,7 @@ func (e *SelectStatement) Eval(input, output Record) (Record, error) {
}
// Update count of records output.
if e.limitValue > -1 {
e.outputCount++
}
e.outputCount++
return output, nil
}