MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-24 06:05:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: [minor] Avoid unnecessary typecasting. (#4828)

Browse Source 
We don't need to typecast identifiers from
their base to type to same type again. This
is not a bug and compiler is fine to skip
it but it is better to avoid if not needed.
This commit is contained in:
Harshavardhana 2017-08-18 11:45:16 -07:00 committed by Dee Koder
parent 7505bac037
commit 2e6ee68409
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/erasure-readfile.go
View File

@ -75,8 +75,8 @@ func (s ErasureStorage) ReadFile(writer io.Writer, volume, path string, offset,
return f, err
}
startOffset = 0
f.Size += int64(n)
length -= int64(n)
f.Size += n
length -= n
}
f.Algorithm = algorithm

4
cmd/signature-v4.go
View File

@ -238,13 +238,13 @@ func doesPresignedSignatureMatch(hashedPayload string, r *http.Request, region s
return ErrRequestNotReadyYet
}
if UTCNow().Sub(pSignValues.Date) > time.Duration(pSignValues.Expires) {
if UTCNow().Sub(pSignValues.Date) > pSignValues.Expires {
return ErrExpiredPresignRequest
}
// Save the date and expires.
t := pSignValues.Date
expireSeconds := int(time.Duration(pSignValues.Expires) / time.Second)
expireSeconds := int(pSignValues.Expires / time.Second)
// Construct the query.
query.Set("X-Amz-Date", t.Format(iso8601Format))

2
cmd/xl-v1-object.go
View File

@ -571,7 +571,7 @@ func (xl xlObjects) PutObject(bucket string, object string, size int64, data io.
// Should return IncompleteBody{} error when reader has fewer bytes
// than specified in request header.
if file.Size < int64(curPartSize) {
if file.Size < curPartSize {
return ObjectInfo{}, traceError(IncompleteBody{})
}

2
cmd/xl-v1-utils.go
View File

@ -117,7 +117,7 @@ func hashOrder(key string, cardinality int) []int {
nums := make([]int, cardinality)
keyCrc := crc32.Checksum([]byte(key), crc32.IEEETable)
start := int(uint32(keyCrc)%uint32(cardinality)) | 1
start := int(keyCrc%uint32(cardinality)) | 1
for i := 1; i <= cardinality; i++ {
nums[i-1] = 1 + ((start + i) % cardinality)
}