MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-02-10 13:18:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

maxConcurrent must be set only once per node (#18303)

Browse Source
This commit is contained in:
Harshavardhana 2023-10-23 21:42:36 -07:00 committed by GitHub
parent 0a284a1a10
commit 2dc917e87f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
cmd/xl-storage-disk-id-check.go
View File

@ -177,13 +177,35 @@ func (e *lockedLastMinuteLatency) total() AccElem {
return e.lastMinuteLatency.getTotal() return e.lastMinuteLatency.getTotal()
} }
var maxConcurrentOnce sync.Once
func newXLStorageDiskIDCheck(storage *xlStorage, healthCheck bool) *xlStorageDiskIDCheck { func newXLStorageDiskIDCheck(storage *xlStorage, healthCheck bool) *xlStorageDiskIDCheck {
// diskMaxConcurrent represents maximum number of running concurrent
// operations for local and (incoming) remote disk operations.
//
// this value is a placeholder it is overridden via ENV for custom settings
// or this default value is used to pick the correct value HDDs v/s NVMe's
diskMaxConcurrent := -1
maxConcurrentOnce.Do(func() {
s := env.Get("_MINIO_DRIVE_MAX_CONCURRENT", "")
if s == "" {
s = env.Get("_MINIO_DISK_MAX_CONCURRENT", "")
}
if s != "" {
diskMaxConcurrent, _ = strconv.Atoi(s)
}
})
if diskMaxConcurrent <= 0 { if diskMaxConcurrent <= 0 {
diskMaxConcurrent = 512 diskMaxConcurrent = 512
if storage.rotational { if storage.rotational {
diskMaxConcurrent = int(storage.nrRequests) / 2
if diskMaxConcurrent == 0 {
diskMaxConcurrent = 32 diskMaxConcurrent = 32
} }
} }
}
diskStartChecking := 16 + diskMaxConcurrent/8 diskStartChecking := 16 + diskMaxConcurrent/8
if diskStartChecking > diskMaxConcurrent { if diskStartChecking > diskMaxConcurrent {
diskStartChecking = diskMaxConcurrent diskStartChecking = diskMaxConcurrent
@ -738,22 +760,7 @@ var diskMaxTimeout = 2 * time.Minute
// diskActiveMonitoring indicates if we have enabled "active" disk monitoring // diskActiveMonitoring indicates if we have enabled "active" disk monitoring
var diskActiveMonitoring = true var diskActiveMonitoring = true
// diskMaxConcurrent represents maximum number of running concurrent
// operations for local and (incoming) remote disk operations.
//
// this value is a placeholder it is overridden via ENV for custom settings
// or this default value is used to pick the correct value HDDs v/s NVMe's
var diskMaxConcurrent = -1
func init() { func init() {
s := env.Get("_MINIO_DRIVE_MAX_CONCURRENT", "")
if s == "" {
s = env.Get("_MINIO_DISK_MAX_CONCURRENT", "")
}
if s != "" {
diskMaxConcurrent, _ = strconv.Atoi(s)
}
d := env.Get("_MINIO_DRIVE_MAX_TIMEOUT", "") d := env.Get("_MINIO_DRIVE_MAX_TIMEOUT", "")
if d == "" { if d == "" {
d = env.Get("_MINIO_DISK_MAX_TIMEOUT", "") d = env.Get("_MINIO_DISK_MAX_TIMEOUT", "")