MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-26 23:25:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

remove replication throttle deadline for objects > 128MiB (#20184)

Browse Source 
context deadline was introduced to avoid a slow transfer from blocking
replication queue(s) shared by other buckets that may not be under throttling.

This PR removes this context deadline for larger objects since they are 
anyway restricted to a limited set of workers. Otherwise, objects would 
get dequeued when the throttle limit is exceeded and cannot proceed 
within the deadline.
This commit is contained in:
Poorna 2024-07-29 15:14:52 -07:00 committed by GitHub
parent 3bc39db34e
commit 2d40433bc1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/bucket-replication.go
View File

@ -1299,7 +1299,7 @@ func (ri ReplicateObjectInfo) replicateObject(ctx context.Context, objectAPI Obj
HeaderSize: headerSize, HeaderSize: headerSize,
} }
newCtx := ctx newCtx := ctx
if globalBucketMonitor.IsThrottled(bucket, tgt.ARN) { if globalBucketMonitor.IsThrottled(bucket, tgt.ARN) && objInfo.Size < minLargeObjSize {
var cancel context.CancelFunc var cancel context.CancelFunc
newCtx, cancel = context.WithTimeout(ctx, throttleDeadline) newCtx, cancel = context.WithTimeout(ctx, throttleDeadline)
defer cancel() defer cancel()
@ -1574,7 +1574,7 @@ applyAction:
HeaderSize: headerSize, HeaderSize: headerSize,
} }
newCtx := ctx newCtx := ctx
if globalBucketMonitor.IsThrottled(bucket, tgt.ARN) { if globalBucketMonitor.IsThrottled(bucket, tgt.ARN) && objInfo.Size < minLargeObjSize {
var cancel context.CancelFunc var cancel context.CancelFunc
newCtx, cancel = context.WithTimeout(ctx, throttleDeadline) newCtx, cancel = context.WithTimeout(ctx, throttleDeadline)
defer cancel() defer cancel()