MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-11 15:03:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: de-duplicate conflicting object names on namespace (#15772)

Browse Source
This commit is contained in:
Harshavardhana 2022-09-30 15:44:21 -07:00 committed by GitHub
parent 45edd27ad7
commit 2aac50571d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/metacache-entries.go
View File

@ -22,6 +22,7 @@ import (
"context"
"errors"
"os"
"path"
"sort"
"strings"
@ -684,7 +685,14 @@ func mergeEntryChannels(ctx context.Context, in []chan metaCacheEntry, out chan<
bestIdx = otherIdx
continue
}
if best.name == other.name {
// We should make sure to avoid objects and directories
// of this fashion such as
// - foo-1
// - foo-1/
// we should avoid this situation by making sure that
// we compare the `foo-1/` after path.Clean() to
// de-dup the entries.
if path.Clean(best.name) == path.Clean(other.name) {
if compareMeta(best, other) {
// Replace "best"
if err := selectFrom(bestIdx); err != nil {