Return ErrContentSHA256Mismatch when sha256sum is invalid (#5188)

This commit is contained in:
Krishnan Parthasarathi
2017-11-16 19:13:04 +00:00
committed by Dee Koder
parent 67f66c40c1
commit 2a0a62b78d
3 changed files with 24 additions and 15 deletions

View File

@@ -114,26 +114,30 @@ func TestHashReaderInvalidArguments(t *testing.T) {
size int64
md5hex, sha256hex string
success bool
expectedErr error
}{
// Invalid md5sum NewReader() will fail.
{
src: bytes.NewReader([]byte("abcd")),
size: 4,
md5hex: "invalid-md5",
success: false,
src: bytes.NewReader([]byte("abcd")),
size: 4,
md5hex: "invalid-md5",
success: false,
expectedErr: BadDigest{},
},
// Invalid sha256 NewReader() will fail.
{
src: bytes.NewReader([]byte("abcd")),
size: 4,
sha256hex: "invalid-sha256",
success: false,
src: bytes.NewReader([]byte("abcd")),
size: 4,
sha256hex: "invalid-sha256",
success: false,
expectedErr: SHA256Mismatch{},
},
// Nested hash reader NewReader() will fail.
{
src: &Reader{src: bytes.NewReader([]byte("abcd"))},
size: 4,
success: false,
src: &Reader{src: bytes.NewReader([]byte("abcd"))},
size: 4,
success: false,
expectedErr: errNestedReader,
},
// Expected inputs, NewReader() will succeed.
{
@@ -151,5 +155,8 @@ func TestHashReaderInvalidArguments(t *testing.T) {
if err == nil && !testCase.success {
t.Errorf("Test %d: Expected error, but got success", i+1)
}
if err != testCase.expectedErr {
t.Errorf("Test %d: Expected error %v, but got %v", i+1, testCase.expectedErr, err)
}
}
}