mirror of
https://github.com/minio/minio.git
synced 2025-11-10 05:59:43 -05:00
Check if SSL is configured to validate input arguments (#5252)
This PR handles following situations - secure endpoints provided, server should fail to start if TLS is not configured - insecure endpoints provided, server starts ignoring if TLS is configured or not. Fixes #5251
This commit is contained in:
committed by
Nitish Tiwari
parent
043e030a4a
commit
2755a0b763
@@ -158,6 +158,11 @@ func serverMain(ctx *cli.Context) {
|
||||
globalPublicCerts, globalRootCAs, globalTLSCertificate, globalIsSSL, err = getSSLConfig()
|
||||
fatalIf(err, "Invalid SSL certificate file")
|
||||
|
||||
// Is distributed setup, error out if no certificates are found for HTTPS endpoints.
|
||||
if globalIsDistXL && globalEndpoints.IsHTTPS() && !globalIsSSL {
|
||||
fatalIf(errInvalidArgument, "No certificates found for HTTPS endpoints (%s)", globalEndpoints)
|
||||
}
|
||||
|
||||
if !quietFlag {
|
||||
// Check for new updates from dl.minio.io.
|
||||
mode := globalMinioModeFS
|
||||
@@ -182,7 +187,6 @@ func serverMain(ctx *cli.Context) {
|
||||
initNSLock(globalIsDistXL)
|
||||
|
||||
// Configure server.
|
||||
// Declare handler to avoid lint errors.
|
||||
var handler http.Handler
|
||||
handler, err = configureServerHandler(globalEndpoints)
|
||||
fatalIf(err, "Unable to configure one of server's RPC services.")
|
||||
|
||||
Reference in New Issue
Block a user