Kafka notify: support batched commits for queue store (#20377)

The items will be saved per target batch and will be committed to the queue store when the batch is full Also, periodically commit the batched items to the queue store based on configured commit_timeout; default is 30s; Bonus: compress queue store multi writes
2025-11-07 21:02:58 -05:00 · 2024-09-07 04:36:30 +05:30
parent 0f1e8db4c5
commit 261111e728
20 changed files with 907 additions and 397 deletions
--- a/internal/store/store_test.go
+++ b/internal/store/store_test.go
@@ -0,0 +1,146 @@
+// Copyright (c) 2015-2024 MinIO, Inc.
+//
+// This file is part of MinIO Object Storage stack
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package store
+
+import (
+	"testing"
+)
+
+func TestKeyString(t *testing.T) {
+	testCases := []struct {
+		key            Key
+		expectedString string
+	}{
+		{
+			key: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Extension: ".event",
+			},
+			expectedString: "01894394-d046-4783-ba0d-f1c6885790dc.event",
+		},
+		{
+			key: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Compress:  true,
+				Extension: ".event",
+				ItemCount: 100,
+			},
+			expectedString: "100:01894394-d046-4783-ba0d-f1c6885790dc.event.snappy",
+		},
+		{
+			key: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Extension: ".event",
+				ItemCount: 100,
+			},
+			expectedString: "100:01894394-d046-4783-ba0d-f1c6885790dc.event",
+		},
+		{
+			key: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Compress:  true,
+				Extension: ".event",
+				ItemCount: 1,
+			},
+			expectedString: "01894394-d046-4783-ba0d-f1c6885790dc.event.snappy",
+		},
+		{
+			key: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Extension: ".event",
+				ItemCount: 1,
+			},
+			expectedString: "01894394-d046-4783-ba0d-f1c6885790dc.event",
+		},
+	}
+
+	for i, testCase := range testCases {
+		if testCase.expectedString != testCase.key.String() {
+			t.Fatalf("case[%v]: key.String() Expected: %s, got %s", i, testCase.expectedString, testCase.key.String())
+		}
+	}
+}
+
+func TestParseKey(t *testing.T) {
+	testCases := []struct {
+		str         string
+		expectedKey Key
+	}{
+		{
+			str: "01894394-d046-4783-ba0d-f1c6885790dc.event",
+			expectedKey: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Extension: ".event",
+				ItemCount: 1,
+			},
+		},
+		{
+			str: "100:01894394-d046-4783-ba0d-f1c6885790dc.event.snappy",
+			expectedKey: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Compress:  true,
+				Extension: ".event",
+				ItemCount: 100,
+			},
+		},
+		{
+			str: "100:01894394-d046-4783-ba0d-f1c6885790dc.event",
+			expectedKey: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Extension: ".event",
+				ItemCount: 100,
+			},
+		},
+		{
+			str: "01894394-d046-4783-ba0d-f1c6885790dc.event.snappy",
+			expectedKey: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Compress:  true,
+				Extension: ".event",
+				ItemCount: 1,
+			},
+		},
+		{
+			str: "01894394-d046-4783-ba0d-f1c6885790dc.event",
+			expectedKey: Key{
+				Name:      "01894394-d046-4783-ba0d-f1c6885790dc",
+				Extension: ".event",
+				ItemCount: 1,
+			},
+		},
+	}
+
+	for i, testCase := range testCases {
+		key := parseKey(testCase.str)
+		if testCase.expectedKey.Name != key.Name {
+			t.Fatalf("case[%v]: Expected key.Name: %v, got %v", i, testCase.expectedKey.Name, key.Name)
+		}
+		if testCase.expectedKey.Compress != key.Compress {
+			t.Fatalf("case[%v]: Expected key.Compress: %v, got %v", i, testCase.expectedKey.Compress, key.Compress)
+		}
+		if testCase.expectedKey.Extension != key.Extension {
+			t.Fatalf("case[%v]: Expected key.Extension: %v, got %v", i, testCase.expectedKey.Extension, key.Extension)
+		}
+		if testCase.expectedKey.ItemCount != key.ItemCount {
+			t.Fatalf("case[%v]: Expected key.ItemCount: %v, got %v", i, testCase.expectedKey.ItemCount, key.ItemCount)
+		}
+		if testCase.expectedKey.String() != key.String() {
+			t.Fatalf("case[%v]: Expected key.String(): %v, got %v", i, testCase.expectedKey.String(), key.String())
+		}
+	}
+}