MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-05-21 17:43:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: for DiskInfo call cache disk metrics (#15229)

Browse Source 
Small uploads spend a significant amount of time (~5%) fetching disk info metrics. Also maps are allocated for each call.

Add a 100ms cache to disk metrics.
This commit is contained in:
Klaus Post 2022-07-05 11:02:30 -07:00 committed by GitHub
parent c7e01b139d
commit 2471bdda00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cmd/xl-storage-disk-id-check.go
View File

@ -78,12 +78,16 @@ type xlStorageDiskIDCheck struct {
diskID string diskID string
storage *xlStorage storage *xlStorage
health *diskHealthTracker health *diskHealthTracker
metricsCache timedValue
} }
func (p *xlStorageDiskIDCheck) getMetrics() DiskMetrics { func (p *xlStorageDiskIDCheck) getMetrics() DiskMetrics {
p.metricsCache.Once.Do(func() {
p.metricsCache.TTL = 100 * time.Millisecond
p.metricsCache.Update = func() (interface{}, error) {
diskMetric := DiskMetrics{ diskMetric := DiskMetrics{
APILatencies: make(map[string]uint64), APILatencies: make(map[string]uint64, len(p.apiLatencies)),
APICalls: make(map[string]uint64), APICalls: make(map[string]uint64, len(p.apiCalls)),
} }
for i, v := range p.apiLatencies { for i, v := range p.apiLatencies {
diskMetric.APILatencies[storageMetric(i).String()] = v.value() diskMetric.APILatencies[storageMetric(i).String()] = v.value()
@ -91,7 +95,11 @@ func (p *xlStorageDiskIDCheck) getMetrics() DiskMetrics {
for i := range p.apiCalls { for i := range p.apiCalls {
diskMetric.APICalls[storageMetric(i).String()] = atomic.LoadUint64(&p.apiCalls[i]) diskMetric.APICalls[storageMetric(i).String()] = atomic.LoadUint64(&p.apiCalls[i])
} }
return diskMetric return diskMetric, nil
}
})
m, _ := p.metricsCache.Get()
return m.(DiskMetrics)
} }
type lockedLastMinuteLatency struct { type lockedLastMinuteLatency struct {