MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-26 07:05:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

grafana: Remove minio_s3_requests_errors_total metric (#17094)

Browse Source
This commit is contained in:
Anis Eleuch 2023-04-27 18:55:30 +01:00 committed by GitHub
parent b28d391a22
commit 2448a9e047
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 98 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/object-handlers.go
View File

@ -544,7 +544,7 @@ func (api objectAPIHandlers) getObjectHandler(ctx context.Context, objectAPI Obj
return return
} }
if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients
logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client %w", err)) logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client: %w", err))
} }
return return
} }
@ -555,7 +555,7 @@ func (api objectAPIHandlers) getObjectHandler(ctx context.Context, objectAPI Obj
return return
} }
if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients
logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client %w", err)) logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client: %w", err))
} }
return return
} }

4
cmd/s3-zip-handlers.go
View File

@ -224,7 +224,7 @@ func (api objectAPIHandlers) getObjectInArchiveFileHandler(ctx context.Context,
return return
} }
if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients
logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client %w", err)) logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client: %w", err))
} }
return return
} }
@ -235,7 +235,7 @@ func (api objectAPIHandlers) getObjectInArchiveFileHandler(ctx context.Context,
return return
} }
if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients if !xnet.IsNetworkOrHostDown(err, true) { // do not need to log disconnected clients
logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client %w", err)) logger.LogIf(ctx, fmt.Errorf("Unable to write all the data to client: %w", err))
} }
return return
} }

96
docs/metrics/prometheus/grafana/minio-dashboard.json
View File

@ -1742,98 +1742,6 @@
"align": false "align": false
} }
}, },
{
"aliasColors": {
"S3 Errors": "light-red",
"S3 Requests": "light-green"
},
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
},
"fill": 1,
"fillGradient": 0,
"gridPos": {
"h": 10,
"w": 12,
"x": 12,
"y": 12
},
"hiddenSeries": false,
"id": 71,
"legend": {
"avg": false,
"current": false,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": true,
"linewidth": 1,
"nullPointMode": "null",
"options": {
"alertThreshold": true
},
"percentage": false,
"pluginVersion": "9.0.0",
"pointradius": 2,
"points": false,
"renderer": "flot",
"seriesOverrides": [],
"spaceLength": 10,
"stack": false,
"steppedLine": false,
"targets": [
{
"exemplar": true,
"expr": "sum by (server,api) (increase(minio_s3_requests_errors_total{job=\"$scrape_jobs\"}[$__rate_interval]))",
"interval": "1m",
"intervalFactor": 2,
"legendFormat": "{{server,api}}",
"refId": "A",
"datasource": {
"type": "prometheus",
"uid": "${DS_PROMETHEUS}"
}
}
],
"thresholds": [],
"timeRegions": [],
"title": "S3 API Request Error Rate",
"tooltip": {
"shared": true,
"sort": 0,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"mode": "time",
"show": true,
"values": []
},
"yaxes": [
{
"$$hashKey": "object:331",
"format": "none",
"logBase": 1,
"show": true
},
{
"$$hashKey": "object:332",
"format": "short",
"logBase": 1,
"show": false
}
],
"yaxis": {
"align": false
}
},
{ {
"datasource": { "datasource": {
"type": "prometheus", "type": "prometheus",
@ -2088,7 +1996,7 @@
], ],
"thresholds": [], "thresholds": [],
"timeRegions": [], "timeRegions": [],
"title": "S3 API Request Error Rate (5xx)", "title": "S3 API Request 5xx Error Rate",
"tooltip": { "tooltip": {
"shared": true, "shared": true,
"sort": 0, "sort": 0,
@ -2180,7 +2088,7 @@
], ],
"thresholds": [], "thresholds": [],
"timeRegions": [], "timeRegions": [],
"title": "S3 API Request Error Rate (4xx)", "title": "S3 API Request 4xx Error Rate",
"tooltip": { "tooltip": {
"shared": true, "shared": true,
"sort": 0, "sort": 0,