move from 503 -> 499 for disconnected clients

This commit is contained in:
Harshavardhana 2021-08-11 01:02:45 -07:00 committed by Minio Trusted
parent 5aff310b80
commit 23f11cec58

View File

@ -234,6 +234,7 @@ const (
ErrServerNotInitialized
ErrOperationTimedOut
ErrOperationMaxedOut
ErrClientDisconnected
ErrInvalidRequest
// MinIO storage class error codes
ErrInvalidStorageClass
@ -1216,6 +1217,11 @@ var errorCodes = errorCodeMap{
Description: "A timeout occurred while trying to lock a resource, please reduce your request rate",
HTTPStatusCode: http.StatusServiceUnavailable,
},
ErrClientDisconnected: {
Code: "ClientDisconnected",
Description: "Client disconnected before response was ready",
HTTPStatusCode: 499, // No official code, use nginx value.
},
ErrOperationMaxedOut: {
Code: "SlowDown",
Description: "A timeout exceeded while waiting to proceed with the request, please reduce your request rate",
@ -1742,6 +1748,16 @@ func toAPIErrorCode(ctx context.Context, err error) (apiErr APIErrorCode) {
return ErrNone
}
// Only return ErrClientDisconnected if the provided context is actually canceled.
// This way downstream context.Canceled will still report ErrOperationTimedOut
select {
case <-ctx.Done():
if ctx.Err() == context.Canceled {
return ErrClientDisconnected
}
default:
}
switch err {
case errInvalidArgument:
apiErr = ErrAdminInvalidArgument