From 21cdd2bf5dade348a04bb929b26980e93d500233 Mon Sep 17 00:00:00 2001
From: Harshavardhana <harsha@minio.io>
Date: Tue, 1 Aug 2023 22:19:56 -0700
Subject: [PATCH] avoid overwriting metrics on success, save it in defer
 (#17780)

---
 cmd/xl-storage-disk-id-check.go | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/cmd/xl-storage-disk-id-check.go b/cmd/xl-storage-disk-id-check.go
index b237f09f7..e4bd6e1a6 100644
--- a/cmd/xl-storage-disk-id-check.go
+++ b/cmd/xl-storage-disk-id-check.go
@@ -275,9 +275,11 @@ func (p *xlStorageDiskIDCheck) DiskInfo(ctx context.Context, metrics bool) (info
 	si := p.updateStorageMetrics(storageMetricDiskInfo)
 	defer si(&err)
 
-	if metrics {
-		info.Metrics = p.getMetrics()
-	}
+	defer func() {
+		if metrics {
+			info.Metrics = p.getMetrics()
+		}
+	}()
 
 	if p.health.isFaulty() {
 		// if disk is already faulty return faulty for 'mc admin info' output and prometheus alerts.