Use ObjectInfo.ToLifecycleOpts instead of literal values (#12772)

Promote getLifecycleTransitionTier to a method on lifecycle.Lifecycle.

cmd/bucket-lifecycle_test.go

@@ -19,7 +19,6 @@ package cmd
 
 import (
 	"bytes"
-	"context"
 	"net/http"
 	"testing"
 	"time"
@@ -240,46 +239,9 @@ func TestValidateTransitionTier(t *testing.T) {
 			t.Fatalf("Test %d: Failed to parse lifecycle config %v", i+1, err)
 		}
 
-		err = validateTransitionTier(context.Background(), lc)
+		err = validateTransitionTier(lc)
 		if err != tc.expectedErr {
 			t.Fatalf("Test %d: Expected %v but got %v", i+1, tc.expectedErr, err)
 		}
 	}
 }
-
-func TestGetLifecycleTransitionTier(t *testing.T) {
-	lc := lifecycle.Lifecycle{
-		Rules: []lifecycle.Rule{
-			{
-				ID:     "rule-1",
-				Status: "Enabled",
-				Transition: lifecycle.Transition{
-					Days:         lifecycle.TransitionDays(3),
-					StorageClass: "TIER-1",
-				},
-			},
-			{
-				ID:     "rule-2",
-				Status: "Enabled",
-				NoncurrentVersionTransition: lifecycle.NoncurrentVersionTransition{
-					NoncurrentDays: lifecycle.ExpirationDays(3),
-					StorageClass:   "TIER-2",
-				},
-			},
-		},
-	}
-
-	obj1 := lifecycle.ObjectOpts{
-		Name:     "obj1",
-		IsLatest: true,
-	}
-	obj2 := lifecycle.ObjectOpts{
-		Name: "obj2",
-	}
-	if got := getLifeCycleTransitionTier(context.TODO(), &lc, "bucket", obj1); got != "TIER-1" {
-		t.Fatalf("Expected TIER-1 but got %s", got)
-	}
-	if got := getLifeCycleTransitionTier(context.TODO(), &lc, "bucket", obj2); got != "TIER-2" {
-		t.Fatalf("Expected TIER-2 but got %s", got)
-	}
-}