fix: enable go1.17 github ci/cd (#12997)

.github/workflows/go-cross.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        go-version: [1.16.x]
+        go-version: [1.16.x, 1.17.x]
         os: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v2

.github/workflows/go-lint.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        go-version: [1.16.x]
+        go-version: [1.16.x, 1.17.x]
         os: [ubuntu-latest, windows-latest]
     steps:
       - uses: actions/checkout@v2

.github/workflows/go.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        go-version: [1.16.x]
+        go-version: [1.16.x, 1.17.x]
         os: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v2

buildscripts/gen-ldflags.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/disk-cache-check-support_contrib_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 /*

cmd/disk-cache-check-support_other.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/os-dirent_fileino.go

@@ -1,3 +1,4 @@
+//go:build freebsd || openbsd || netbsd
 // +build freebsd openbsd netbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/os-dirent_ino.go

@@ -15,6 +15,7 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+//go:build (linux || darwin) && !appengine
 // +build linux darwin
 // +build !appengine
 

cmd/os-dirent_namelen_bsd.go

@@ -1,3 +1,4 @@
+//go:build darwin || freebsd || openbsd || netbsd
 // +build darwin freebsd openbsd netbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/os-dirent_namelen_linux.go

@@ -1,3 +1,4 @@
+//go:build linux && !appengine
 // +build linux,!appengine
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/os-readdir_other.go

@@ -1,3 +1,4 @@
+//go:build plan9 || solaris
 // +build plan9 solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/os-readdir_unix.go

@@ -1,3 +1,4 @@
+//go:build (linux && !appengine) || darwin || freebsd || netbsd || openbsd
 // +build linux,!appengine darwin freebsd netbsd openbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/os-readdir_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/update_fips.go

@@ -1,3 +1,4 @@
+//go:build fips
 // +build fips
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/update_nofips.go

@@ -1,3 +1,4 @@
+//go:build !fips
 // +build !fips
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/xl-storage_noatime_notsupported.go

@@ -1,3 +1,4 @@
+//go:build windows || darwin || freebsd
 // +build windows darwin freebsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/xl-storage_noatime_supported.go

@@ -1,3 +1,4 @@
+//go:build !windows && !darwin && !freebsd
 // +build !windows,!darwin,!freebsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/xl-storage_unix_test.go

@@ -1,3 +1,4 @@
+//go:build linux || darwin || dragonfly || freebsd || netbsd || openbsd
 // +build linux darwin dragonfly freebsd netbsd openbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

cmd/xl-storage_windows_test.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

docs/sts/assume-role.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

docs/sts/client-grants.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

docs/sts/ldap.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

docs/sts/web-identity.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/config/certs_test.go

@@ -18,10 +18,8 @@
 package config
 
 import (
-	"fmt"
 	"io/ioutil"
 	"os"
-	"runtime"
 	"testing"
 )
 
@@ -155,39 +153,27 @@ M9ofSEt/bdRD
 	}
 	defer os.Remove(tempFile5)
 
-	nonexistentErr := fmt.Errorf("open nonexistent-file: no such file or directory")
-	if runtime.GOOS == "windows" {
-		// Below concatenation is done to get rid of goline error
-		// "error strings should not be capitalized or end with punctuation or a newline"
-		nonexistentErr = fmt.Errorf("open nonexistent-file:" + " The system cannot find the file specified.")
-	}
-
 	testCases := []struct {
 		certFile          string
 		expectedResultLen int
-		expectedErr       error
+		expectedErr       bool
 	}{
-		{"nonexistent-file", 0, nonexistentErr},
+		{"nonexistent-file", 0, true},
-		{tempFile1, 0, fmt.Errorf("Empty public certificate file %s", tempFile1)},
+		{tempFile1, 0, true},
-		{tempFile2, 0, fmt.Errorf("Could not read PEM block from file %s", tempFile2)},
+		{tempFile2, 0, true},
-		{tempFile3, 0, fmt.Errorf("asn1: structure error: sequence tag mismatch")},
+		{tempFile3, 0, true},
-		{tempFile4, 1, nil},
+		{tempFile4, 1, false},
-		{tempFile5, 2, nil},
+		{tempFile5, 2, false},
 	}
 
 	for _, testCase := range testCases {
 		certs, err := ParsePublicCertFile(testCase.certFile)
-
+		if !testCase.expectedErr && err != nil {
-		if testCase.expectedErr == nil {
-			if err != nil {
 			t.Fatalf("error: expected = <nil>, got = %v", err)
 		}
-		} else if err == nil {
+		if testCase.expectedErr && err == nil {
-			t.Fatalf("error: expected = %v, got = <nil>", testCase.expectedErr)
+			t.Fatal("error: expected err, got = <nil>")
-		} else if testCase.expectedErr.Error() != err.Error() {
-			t.Fatalf("error: expected = %v, got = %v", testCase.expectedErr, err)
 		}
-
 		if len(certs) != testCase.expectedResultLen {
 			t.Fatalf("certs: expected = %v, got = %v", testCase.expectedResultLen, len(certs))
 		}

internal/config/identity/openid/ecdsa-sha3_contrib.go

@@ -11,6 +11,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+//go:build !fips
 // +build !fips
 
 package openid

internal/config/identity/openid/rsa-sha3_contrib.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+//go:build !fips
 // +build !fips
 
 package openid

internal/disk/directio_unix.go

@@ -1,3 +1,4 @@
+//go:build linux || netbsd || freebsd
 // +build linux netbsd freebsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/directio_unsupported.go

@@ -1,3 +1,4 @@
+//go:build !linux && !netbsd && !freebsd && !darwin
 // +build !linux,!netbsd,!freebsd,!darwin
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/disk_test.go

@@ -1,3 +1,4 @@
+//go:build !netbsd && !solaris
 // +build !netbsd,!solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/disk_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/disk_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/fdatasync_linux.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/fdatasync_unix.go

@@ -1,3 +1,4 @@
+//go:build freebsd || netbsd || openbsd || darwin
 // +build freebsd netbsd openbsd darwin
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/fdatasync_unsupported.go

@@ -1,3 +1,4 @@
+//go:build !linux && !netbsd && !freebsd && !darwin && !openbsd
 // +build !linux,!netbsd,!freebsd,!darwin,!openbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_bsd.go

@@ -1,3 +1,4 @@
+//go:build darwin || dragonfly
 // +build darwin dragonfly
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_freebsd.go

@@ -1,3 +1,4 @@
+//go:build freebsd
 // +build freebsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_linux.go

@@ -1,3 +1,4 @@
+//go:build linux && !s390x && !arm && !386
 // +build linux,!s390x,!arm,!386
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_linux_32bit.go

@@ -1,3 +1,4 @@
+//go:build (linux && arm) || (linux && 386)
 // +build linux,arm linux,386
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_linux_s390x.go

@@ -1,3 +1,4 @@
+//go:build linux && s390x
 // +build linux,s390x
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_netbsd.go

@@ -1,3 +1,4 @@
+//go:build netbsd
 // +build netbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_openbsd.go

@@ -1,3 +1,4 @@
+//go:build openbsd
 // +build openbsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_solaris.go

@@ -1,3 +1,4 @@
+//go:build solaris
 // +build solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/stat_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/type_bsd.go

@@ -1,3 +1,4 @@
+//go:build darwin || freebsd || dragonfly || openbsd || solaris
 // +build darwin freebsd dragonfly openbsd solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/type_linux.go

@@ -1,3 +1,4 @@
+//go:build linux && !s390x && !arm && !386
 // +build linux,!s390x,!arm,!386
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/disk/type_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/fips/fips.go

@@ -15,6 +15,7 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+//go:build fips && linux && amd64
 // +build fips,linux,amd64
 
 package fips

internal/fips/no_fips.go

@@ -15,6 +15,7 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+//go:build !fips
 // +build !fips
 
 package fips

internal/hash/sha256_fips.go

@@ -15,6 +15,7 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+//go:build fips
 // +build fips
 
 package hash

internal/hash/sha256_nofips.go

@@ -15,6 +15,7 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+//go:build !fips
 // +build !fips
 
 package hash

internal/http/dial_linux.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/http/dial_others.go

@@ -1,3 +1,4 @@
+//go:build !linux
 // +build !linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/http/listen_nix.go

@@ -1,3 +1,4 @@
+//go:build linux || darwin || dragonfly || freebsd || netbsd || openbsd || rumprun
 // +build linux darwin dragonfly freebsd netbsd openbsd rumprun
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/http/listen_others.go

@@ -1,3 +1,4 @@
+//go:build windows || plan9 || solaris
 // +build windows plan9 solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/ioutil/append-file_nix.go

@@ -1,3 +1,4 @@
+//go:build !windows
 // +build !windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/ioutil/read_file_noatime_notsupported.go

@@ -1,3 +1,4 @@
+//go:build windows || darwin || freebsd
 // +build windows darwin freebsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/ioutil/read_file_noatime_supported.go

@@ -1,3 +1,4 @@
+//go:build !windows && !darwin && !freebsd
 // +build !windows,!darwin,!freebsd
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/lock/lock_nix.go

@@ -1,3 +1,4 @@
+//go:build !windows && !plan9 && !solaris
 // +build !windows,!plan9,!solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/lock/lock_solaris.go

@@ -1,3 +1,4 @@
+//go:build solaris
 // +build solaris
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/lock/lock_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/lock/lock_windows_test.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/mountinfo/mountinfo.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/mountinfo/mountinfo_linux.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/mountinfo/mountinfo_linux_test.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/mountinfo/mountinfo_others.go

@@ -1,3 +1,4 @@
+//go:build !linux && !windows
 // +build !linux,!windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/mountinfo/mountinfo_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/s3select/genmessage.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/s3select/unused-errors.go

@@ -1,3 +1,4 @@
+//go:build ignore
 // +build ignore
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/smart/nvme.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

internal/smart/smart.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 // Copyright (c) 2015-2021 MinIO, Inc.

main_contrib_test.go

@@ -1,3 +1,4 @@
+//go:build testrunmain
 // +build testrunmain
 
 /*