From 2020afd200c35f8c085b551ec41c7611793d89e1 Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Tue, 30 Aug 2016 12:52:19 -0700 Subject: [PATCH] server: http.Server do not add deadlines causes issues. (#2581) Adding deadlines is a no go since Golang doesn't back off the timers if there is an active i/o in progress. It is meant to be for applications to handle this themselves and manually progress the deadlines. Fixes #2561 --- cmd/server-mux.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/server-mux.go b/cmd/server-mux.go index 3ea309a6c..4f9bfce43 100644 --- a/cmd/server-mux.go +++ b/cmd/server-mux.go @@ -188,9 +188,9 @@ func NewMuxServer(addr string, handler http.Handler) *MuxServer { m := &MuxServer{ Server: http.Server{ Addr: addr, - // Adding timeout of 10 minutes for unresponsive client connections. - ReadTimeout: 10 * time.Minute, - WriteTimeout: 10 * time.Minute, + // Do not add any timeouts Golang net.Conn + // closes connections right after 10mins even + // if they are not idle. Handler: handler, MaxHeaderBytes: 1 << 20, },