MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-01-25 21:53:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Properly load creds from env and save them when server cmd is executed (#2970)

Browse Source
This commit is contained in:
Anis Elleuch 2016-10-18 07:14:41 +01:00 committed by Harshavardhana
parent 0f26ec8095
commit 2005d656e6
2 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
cmd/main.go
View File

@ -174,6 +174,23 @@ func Main() {
err := initConfig() err := initConfig()
fatalIf(err, "Unable to initialize minio config.") fatalIf(err, "Unable to initialize minio config.")
// Fetch access keys from environment variables and update the config.
accessKey := os.Getenv("MINIO_ACCESS_KEY")
secretKey := os.Getenv("MINIO_SECRET_KEY")
if accessKey != "" && secretKey != "" {
if !isValidAccessKey.MatchString(accessKey) {
fatalIf(errInvalidArgument, "Invalid access key.")
}
if !isValidSecretKey.MatchString(secretKey) {
fatalIf(errInvalidArgument, "Invalid secret key.")
}
// Set new credentials.
serverConfig.SetCredential(credential{
AccessKeyID: accessKey,
SecretAccessKey: secretKey,
})
}
// Enable all loggers by now. // Enable all loggers by now.
enableLoggers() enableLoggers()

25
cmd/server-main.go
View File

@ -174,28 +174,11 @@ func initServerConfig(c *cli.Context) {
fatalIf(err, "Unable to convert MINIO_CACHE_EXPIRY=%s environment variable into its time.Duration value.", cacheExpiryStr) fatalIf(err, "Unable to convert MINIO_CACHE_EXPIRY=%s environment variable into its time.Duration value.", cacheExpiryStr)
} }
// Fetch access keys from environment variables if any and update the config. // When credentials inherited from the env, server cmd has to save them in the disk
accessKey := os.Getenv("MINIO_ACCESS_KEY") if os.Getenv("MINIO_ACCESS_KEY") != "" && os.Getenv("MINIO_SECRET_KEY") != "" {
secretKey := os.Getenv("MINIO_SECRET_KEY") // Env credentials are already loaded in serverConfig, just save in the disk
// Validate if both keys are specified and they are valid save them.
if accessKey != "" && secretKey != "" {
if !isValidAccessKey.MatchString(accessKey) {
fatalIf(errInvalidArgument, "Invalid access key.")
}
if !isValidSecretKey.MatchString(secretKey) {
fatalIf(errInvalidArgument, "Invalid secret key.")
}
// Set new credentials.
serverConfig.SetCredential(credential{
AccessKeyID: accessKey,
SecretAccessKey: secretKey,
})
// Save new config.
err = serverConfig.Save() err = serverConfig.Save()
fatalIf(err, "Unable to save config.") fatalIf(err, "Unable to save credentials in the disk.")
} }
// Set maxOpenFiles, This is necessary since default operating // Set maxOpenFiles, This is necessary since default operating