mirror of
https://github.com/minio/minio.git
synced 2025-01-11 23:13:23 -05:00
Use +Inf label additionally for Histogram metrics (#18807)
This commit is contained in:
parent
7c0673279b
commit
19387cafab
@ -20,6 +20,7 @@ package cmd
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"math"
|
||||||
"net/http"
|
"net/http"
|
||||||
"runtime"
|
"runtime"
|
||||||
"strconv"
|
"strconv"
|
||||||
@ -1715,6 +1716,17 @@ func getHistogramMetrics(hist *prometheus.HistogramVec, desc MetricDescription)
|
|||||||
}
|
}
|
||||||
metrics = append(metrics, metric)
|
metrics = append(metrics, metric)
|
||||||
}
|
}
|
||||||
|
// add metrics with +Inf label
|
||||||
|
labels1 := make(map[string]string)
|
||||||
|
for _, lp := range dtoMetric.GetLabel() {
|
||||||
|
labels1[*lp.Name] = *lp.Value
|
||||||
|
}
|
||||||
|
labels1["le"] = fmt.Sprintf("%.3f", math.Inf(+1))
|
||||||
|
metrics = append(metrics, Metric{
|
||||||
|
Description: desc,
|
||||||
|
VariableLabels: labels1,
|
||||||
|
Value: dtoMetric.Counter.GetValue(),
|
||||||
|
})
|
||||||
}
|
}
|
||||||
return metrics
|
return metrics
|
||||||
}
|
}
|
||||||
|
@ -81,7 +81,8 @@ func TestGetHistogramMetrics(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
metrics := getHistogramMetrics(ttfbHist, getBucketTTFBDistributionMD())
|
metrics := getHistogramMetrics(ttfbHist, getBucketTTFBDistributionMD())
|
||||||
if expPoints := len(labels) * len(histBuckets); expPoints != len(metrics) {
|
// additional labels for +Inf for all histogram metrics
|
||||||
|
if expPoints := len(labels) * (len(histBuckets) + 1); expPoints != len(metrics) {
|
||||||
t.Fatalf("Expected %v data points but got %v", expPoints, len(metrics))
|
t.Fatalf("Expected %v data points but got %v", expPoints, len(metrics))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user