MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-24 22:25:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

replication resync: report only the on-disk status (#18017)

Browse Source 
Avoid reporting in-memory status since results can vary if different
nodes are queried, resync always runs at a single node.
This commit is contained in:
Poorna 2023-09-13 10:58:38 -07:00 committed by GitHub
parent 8b8be2695f
commit 18e23bafd9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
cmd/bucket-replication-handlers.go
View File

@ -476,27 +476,17 @@ func (api objectAPIHandlers) ResetBucketReplicationStatusHandler(w http.Response
writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL) writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL)
return return
} }
var tgtStats map[string]TargetReplicationResyncStatus brs, err := loadBucketResyncMetadata(ctx, bucket, objectAPI)
globalReplicationPool.resyncer.RLock() if err != nil {
brs, ok := globalReplicationPool.resyncer.statusMap[bucket] writeErrorResponse(ctx, w, errorCodes.ToAPIErrWithErr(ErrBadRequest, InvalidArgument{
if ok { Bucket: bucket,
tgtStats = brs.cloneTgtStats() Err: fmt.Errorf("replication resync status not available for %s (%s)", arn, err.Error()),
} }), r.URL)
globalReplicationPool.resyncer.RUnlock() return
if !ok {
brs, err = loadBucketResyncMetadata(ctx, bucket, objectAPI)
if err != nil {
writeErrorResponse(ctx, w, errorCodes.ToAPIErrWithErr(ErrBadRequest, InvalidArgument{
Bucket: bucket,
Err: fmt.Errorf("No replication resync status available for %s", arn),
}), r.URL)
return
}
tgtStats = brs.cloneTgtStats()
} }
var rinfo ResyncTargetsInfo var rinfo ResyncTargetsInfo
for tarn, st := range tgtStats { for tarn, st := range brs.TargetsMap {
if arn != "" && tarn != arn { if arn != "" && tarn != arn {
continue continue
} }