MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-22 03:24:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid goroutine leak after timeouts in PeerMetrics (#16569)

Browse Source
This commit is contained in:
jiuker 2023-02-09 01:11:16 +08:00 committed by GitHub
parent c97f50e274
commit 1828fb212a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/peer-rest-client.go
View File

@ -838,14 +838,20 @@ func (client *peerRESTClient) GetPeerMetrics(ctx context.Context) (<-chan Metric
dec := gob.NewDecoder(respBody) dec := gob.NewDecoder(respBody)
ch := make(chan Metric) ch := make(chan Metric)
go func(ch chan<- Metric) { go func(ch chan<- Metric) {
defer func() {
xhttp.DrainBody(respBody)
close(ch)
}()
for { for {
var metric Metric var metric Metric
if err := dec.Decode(&metric); err != nil { if err := dec.Decode(&metric); err != nil {
xhttp.DrainBody(respBody)
close(ch)
return return
} }
ch <- metric select {
case <-ctx.Done():
return
case ch <- metric:
}
} }
}(ch) }(ch)
return ch, nil return ch, nil