mirror of
https://github.com/minio/minio.git
synced 2024-12-24 22:25:54 -05:00
add parallel workers to perform replication in parallel (#10525)
set the concurrency for replication be to runtime.NumCPU()/2
This commit is contained in:
parent
a5da9120f3
commit
17e17da00d
@ -20,6 +20,7 @@ import (
|
|||||||
"context"
|
"context"
|
||||||
"fmt"
|
"fmt"
|
||||||
"net/http"
|
"net/http"
|
||||||
|
"runtime"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
@ -293,29 +294,47 @@ func (r *replicationState) queueReplicaTask(oi ObjectInfo) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
var globalReplicationState *replicationState
|
var (
|
||||||
|
globalReplicationState *replicationState
|
||||||
|
// TODO: currently keeping it conservative
|
||||||
|
// but eventually can be tuned in future,
|
||||||
|
// take only half the CPUs for replication
|
||||||
|
// conservatively.
|
||||||
|
globalReplicationConcurrent = runtime.GOMAXPROCS(0) / 2
|
||||||
|
)
|
||||||
|
|
||||||
func newReplicationState() *replicationState {
|
func newReplicationState() *replicationState {
|
||||||
return &replicationState{
|
return &replicationState{
|
||||||
// TODO: currently keeping it conservative
|
replicaCh: make(chan ObjectInfo, globalReplicationConcurrent*2),
|
||||||
// but eventually can be tuned in future
|
|
||||||
replicaCh: make(chan ObjectInfo, 100),
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// addWorker creates a new worker to process tasks
|
||||||
|
func (r *replicationState) addWorker(ctx context.Context, objectAPI ObjectLayer) {
|
||||||
|
// Add a new worker.
|
||||||
|
go func() {
|
||||||
|
for {
|
||||||
|
select {
|
||||||
|
case <-ctx.Done():
|
||||||
|
close(r.replicaCh)
|
||||||
|
return
|
||||||
|
case oi, ok := <-r.replicaCh:
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
replicateObject(ctx, oi, objectAPI)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
}
|
||||||
|
|
||||||
func initBackgroundReplication(ctx context.Context, objectAPI ObjectLayer) {
|
func initBackgroundReplication(ctx context.Context, objectAPI ObjectLayer) {
|
||||||
if globalReplicationState == nil {
|
if globalReplicationState == nil {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
go func() {
|
|
||||||
defer close(globalReplicationState.replicaCh)
|
// Start with globalReplicationConcurrent.
|
||||||
for {
|
for i := 0; i < globalReplicationConcurrent; i++ {
|
||||||
select {
|
globalReplicationState.addWorker(ctx, objectAPI)
|
||||||
case <-ctx.Done():
|
}
|
||||||
return
|
|
||||||
case oi := <-globalReplicationState.replicaCh:
|
|
||||||
replicateObject(ctx, oi, objectAPI)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user