fix: optimize listMultipartUploads to serve via local disks (#18034)

and remove unused getLoadBalancedDisks()
This commit is contained in:
Harshavardhana
2023-09-15 08:34:03 -07:00
committed by GitHub
parent 7b92687397
commit 1647fc7edc
2 changed files with 7 additions and 57 deletions

View File

@@ -269,7 +269,13 @@ func (er erasureObjects) ListMultipartUploads(ctx context.Context, bucket, objec
var uploadIDs []string
var disk StorageAPI
for _, disk = range er.getLoadBalancedDisks(true) {
disks := er.getLoadBalancedLocalDisks()
if len(disks) == 0 {
// using er.getLoadBalancedLocalDisks() has one side-affect where
// on a pooled setup all disks are remote, add a fallback
disks = er.getOnlineDisks()
}
for _, disk = range disks {
uploadIDs, err = disk.ListDir(ctx, minioMetaMultipartBucket, er.getMultipartSHADir(bucket, object), -1)
if err != nil {
if errors.Is(err, errDiskNotFound) {