MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-03-03 15:20:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

audit: Try to send audit even if the status is offline (#18458)

Browse Source 
Currently, once the audit becomes offline, there is no code that tries
to reconnect to the audit, at the same time Send() quickly returns with
an error without really trying to send a message the audit endpoint; so
the audit endpoint will never be online again.

Fixing this behavior; the current downside is that we miss printing some
logs when the audit becomes offline; however this information is
available in prometheus

Later, we can refactor internal/logger so the http endpoint can send errors to
console target.
This commit is contained in:
Anis Eleuch 2023-11-17 10:40:28 -08:00 committed by GitHub
parent e4b619ce1a
commit 12f570a307
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/logger/target/http/http.go
View File

@ -379,10 +379,6 @@ func (h *Target) SendFromStore(key store.Key) (err error) {
// Messages are queued in the disk if the store is enabled // Messages are queued in the disk if the store is enabled
// If Cancel has been called the message is ignored. // If Cancel has been called the message is ignored.
func (h *Target) Send(ctx context.Context, entry interface{}) error { func (h *Target) Send(ctx context.Context, entry interface{}) error {
if atomic.LoadInt32(&h.status) == statusOffline {
h.config.LogOnce(ctx, fmt.Errorf("target %s is offline", h.Endpoint()), h.Endpoint())
return nil
}
if atomic.LoadInt32(&h.status) == statusClosed { if atomic.LoadInt32(&h.status) == statusClosed {
return nil return nil
} }