MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-20 02:27:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: upon write failure on disk journal close the file properly (#18183)

Browse Source 
close the file properly before dereferencing *os.File,
this can silently leak fd's in rare cases.

This PR fixes this properly.
This commit is contained in:
Harshavardhana 2023-10-08 12:17:08 -07:00 committed by GitHub
parent 18550387d5
commit 11544a62aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/tier-journal.go
View File

@ -195,6 +195,10 @@ func (jd *tierDiskJournal) addEntry(je jentry) error {
defer jd.Unlock() defer jd.Unlock()
_, err = jd.file.Write(b) _, err = jd.file.Write(b)
if err != nil { if err != nil {
// Do not leak fd here, close the file properly.
Fdatasync(jd.file)
_ = jd.file.Close()
jd.file = nil // reset to allow subsequent reopen when file/disk is available. jd.file = nil // reset to allow subsequent reopen when file/disk is available.
} }
return err return err