mirror of
https://github.com/minio/minio.git
synced 2024-12-24 22:25:54 -05:00
Add debugging for mutex, tracing (#6522)
This commit is contained in:
parent
20378821cf
commit
1111419d4a
@ -286,9 +286,9 @@ type StartProfilingResult struct {
|
||||
Error string `json:"error"`
|
||||
}
|
||||
|
||||
// StartProfilingHandler - POST /minio/admin/v1/profiling/start/{profiler}
|
||||
// StartProfilingHandler - POST /minio/admin/v1/profiling/start?profilerType={profilerType}
|
||||
// ----------
|
||||
// Enable profiling information
|
||||
// Enable server profiling
|
||||
func (a adminAPIHandlers) StartProfilingHandler(w http.ResponseWriter, r *http.Request) {
|
||||
adminAPIErr := checkAdminRequestAuthType(r, "")
|
||||
if adminAPIErr != ErrNone {
|
||||
@ -297,7 +297,7 @@ func (a adminAPIHandlers) StartProfilingHandler(w http.ResponseWriter, r *http.R
|
||||
}
|
||||
|
||||
vars := mux.Vars(r)
|
||||
profiler := vars["profiler"]
|
||||
profiler := vars["profilerType"]
|
||||
|
||||
startProfilingResult := make([]StartProfilingResult, len(globalAdminPeers))
|
||||
|
||||
|
@ -61,7 +61,8 @@ func registerAdminRouter(router *mux.Router) {
|
||||
adminV1Router.Methods(http.MethodPost).Path("/heal/{bucket}/{prefix:.*}").HandlerFunc(httpTraceAll(adminAPI.HealHandler))
|
||||
|
||||
// Profiling operations
|
||||
adminV1Router.Methods(http.MethodPost).Path("/profiling/start/{profiler}").HandlerFunc(httpTraceAll(adminAPI.StartProfilingHandler))
|
||||
adminV1Router.Methods(http.MethodPost).Path("/profiling/start").HandlerFunc(httpTraceAll(adminAPI.StartProfilingHandler)).
|
||||
Queries("profilerType", "{profilerType:.*}")
|
||||
adminV1Router.Methods(http.MethodGet).Path("/profiling/download").HandlerFunc(httpTraceAll(adminAPI.DownloadProfilingHandler))
|
||||
|
||||
/// Config operations
|
||||
|
@ -226,6 +226,10 @@ func startProfiler(profilerType, dirPath string) (interface {
|
||||
profiler = profile.Start(profile.MemProfile, profile.NoShutdownHook, profile.ProfilePath(dirPath))
|
||||
case "block":
|
||||
profiler = profile.Start(profile.BlockProfile, profile.NoShutdownHook, profile.ProfilePath(dirPath))
|
||||
case "mutex":
|
||||
profiler = profile.Start(profile.MutexProfile, profile.NoShutdownHook, profile.ProfilePath(dirPath))
|
||||
case "trace":
|
||||
profiler = profile.Start(profile.TraceProfile, profile.NoShutdownHook, profile.ProfilePath(dirPath))
|
||||
default:
|
||||
return nil, errors.New("profiler type unknown")
|
||||
}
|
||||
|
@ -176,7 +176,7 @@ func (c *AdminClient) TraceOff() {
|
||||
type requestData struct {
|
||||
customHeaders http.Header
|
||||
queryValues url.Values
|
||||
relPath string // Url path relative to admin API base endpoint
|
||||
relPath string // URL path relative to admin API base endpoint
|
||||
content []byte
|
||||
}
|
||||
|
||||
|
@ -24,20 +24,20 @@ import (
|
||||
"io"
|
||||
"io/ioutil"
|
||||
"net/http"
|
||||
"net/url"
|
||||
)
|
||||
|
||||
// ProfilerType represents the profiler type
|
||||
// passed to the profiler subsystem, currently
|
||||
// it can be only "cpu", "mem" or "block"
|
||||
// passed to the profiler subsystem.
|
||||
type ProfilerType string
|
||||
|
||||
// Different supported profiler types.
|
||||
const (
|
||||
// ProfilerCPU represents CPU profiler type
|
||||
ProfilerCPU = ProfilerType("cpu")
|
||||
// ProfilerMEM represents MEM profiler type
|
||||
ProfilerMEM = ProfilerType("mem")
|
||||
// ProfilerBlock represents Block profiler type
|
||||
ProfilerBlock = ProfilerType("block")
|
||||
ProfilerCPU ProfilerType = "cpu" // represents CPU profiler type
|
||||
ProfilerMEM = "mem" // represents MEM profiler type
|
||||
ProfilerBlock = "block" // represents Block profiler type
|
||||
ProfilerMutex = "mutex" // represents Mutex profiler type
|
||||
ProfilerTrace = "trace" // represents Trace profiler type
|
||||
)
|
||||
|
||||
// StartProfilingResult holds the result of starting
|
||||
@ -51,9 +51,11 @@ type StartProfilingResult struct {
|
||||
// StartProfiling makes an admin call to remotely start profiling on a standalone
|
||||
// server or the whole cluster in case of a distributed setup.
|
||||
func (adm *AdminClient) StartProfiling(profiler ProfilerType) ([]StartProfilingResult, error) {
|
||||
path := fmt.Sprintf("/v1/profiling/start/%s", profiler)
|
||||
v := url.Values{}
|
||||
v.Set("profilerType", string(profiler))
|
||||
resp, err := adm.executeMethod("POST", requestData{
|
||||
relPath: path,
|
||||
relPath: "/v1/profiling/start",
|
||||
queryValues: v,
|
||||
})
|
||||
defer closeResponse(resp)
|
||||
if err != nil {
|
||||
|
Loading…
Reference in New Issue
Block a user