MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2024-12-25 06:35:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add randomize sleep times for lock checkers (#8628)

Browse Source
This commit is contained in:
Harshavardhana 2019-12-11 10:57:05 -08:00 committed by kannappanr
parent 3e9ab5f4a9
commit 10b2f15f6f
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/lock-rest-server.go
View File

@ -29,7 +29,7 @@ import (
const ( const (
// Lock maintenance interval. // Lock maintenance interval.
lockMaintenanceInterval = 1 * time.Minute lockMaintenanceInterval = 30 * time.Second
// Lock validity check interval. // Lock validity check interval.
lockValidityCheckInterval = 2 * time.Minute lockValidityCheckInterval = 2 * time.Minute
@ -234,9 +234,6 @@ func lockMaintenance(interval time.Duration) {
// Start lock maintenance from all lock servers. // Start lock maintenance from all lock servers.
func startLockMaintenance() { func startLockMaintenance() {
// Start with random sleep time, so as to avoid "synchronous checks" between servers
time.Sleep(time.Duration(rand.Float64() * float64(lockMaintenanceInterval)))
// Initialize a new ticker with a minute between each ticks. // Initialize a new ticker with a minute between each ticks.
ticker := time.NewTicker(lockMaintenanceInterval) ticker := time.NewTicker(lockMaintenanceInterval)
// Stop the timer upon service closure and cleanup the go-routine. // Stop the timer upon service closure and cleanup the go-routine.
@ -248,6 +245,11 @@ func startLockMaintenance() {
case <-GlobalServiceDoneCh: case <-GlobalServiceDoneCh:
return return
case <-ticker.C: case <-ticker.C:
// Start with random sleep time, so as to avoid
// "synchronous checks" between servers
r := rand.New(rand.NewSource(UTCNow().UnixNano()))
duration := time.Duration(r.Float64() * float64(lockMaintenanceInterval))
time.Sleep(duration)
lockMaintenance(lockValidityCheckInterval) lockMaintenance(lockValidityCheckInterval)
} }
} }