MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-11-20 01:50:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

Disallow only policy statements which are exactly same (#8785)

Browse Source
This commit is contained in:
Harshavardhana
2020-01-09 19:29:57 -08:00
committed by GitHub
parent 656146b699
commit 0a70bc24ac
7 changed files with 86 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/policy/policy.go
View File

@@ -92,18 +92,15 @@ func (policy Policy) isValid() error {
continue
}
principals := policy.Statements[i].Principal.Intersection(statement.Principal)
if principals.IsEmpty() {
if !policy.Statements[i].Principal.Equals(statement.Principal) {
continue
}
actions := policy.Statements[i].Actions.Intersection(statement.Actions)
if len(actions) == 0 {
if !policy.Statements[i].Actions.Equals(statement.Actions) {
continue
}
resources := policy.Statements[i].Resources.Intersection(statement.Resources)
if len(resources) == 0 {
if !policy.Statements[i].Resources.Equals(statement.Resources) {
continue
}
@@ -112,7 +109,9 @@ func (policy Policy) isValid() error {
}
return Errorf("duplicate principal %v, actions %v, resouces %v found in statements %v, %v",
principals, actions, resources, policy.Statements[i], statement)
statement.Principal, statement.Actions,
statement.Resources, policy.Statements[i],
statement)
}
}