MyFavMirrors/minio
1
0
Fork 0
mirror of https://github.com/minio/minio.git synced 2025-04-18 17:55:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix buffered streams missing final entries (#21122)

Browse Source 
On buffered streams the final entries could be missing, if a lot 
are delivered when stream ends.

Fixes end-of-stream cancelling return of final entries by canceling
with the StreamEOF error.
This commit is contained in:
Klaus Post 2025-04-10 08:29:19 -07:00 committed by GitHub
parent 2b34e5b9ae
commit 02a67cbd2a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/grid/connection.go
View File

@ -1634,10 +1634,9 @@ func (c *Connection) handleMuxServerMsg(ctx context.Context, m message) {
} }
if m.Flags&FlagEOF != 0 { if m.Flags&FlagEOF != 0 {
if v.cancelFn != nil && m.Flags&FlagPayloadIsErr == 0 { if v.cancelFn != nil && m.Flags&FlagPayloadIsErr == 0 {
// We must obtain the lock before calling cancelFn // We must obtain the lock before closing
// Otherwise others may pick up the error before close is called. // Otherwise others may pick up the error before close is called.
v.respMu.Lock() v.respMu.Lock()
v.cancelFn(errStreamEOF)
v.closeLocked() v.closeLocked()
v.respMu.Unlock() v.respMu.Unlock()
} else { } else {