From 01bfc785357c2ed3b5464e3088b1f5475ed3c81f Mon Sep 17 00:00:00 2001 From: jiuker <2818723467@qq.com> Date: Mon, 13 May 2024 13:52:27 +0800 Subject: [PATCH] Optimization: reuse hashedSecret when LookupConfig (#19724) --- internal/config/identity/openid/openid.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/internal/config/identity/openid/openid.go b/internal/config/identity/openid/openid.go index 523891fd8..e5f59ba40 100644 --- a/internal/config/identity/openid/openid.go +++ b/internal/config/identity/openid/openid.go @@ -509,13 +509,11 @@ func (r *Config) GetSettings() madmin.OpenIDSettings { return res } h := sha256.New() + hashedSecret := "" for arn, provCfg := range r.arnProviderCfgsMap { - hashedSecret := "" - { - h.Reset() - h.Write([]byte(provCfg.ClientSecret)) - hashedSecret = base64.RawURLEncoding.EncodeToString(h.Sum(nil)) - } + h.Write([]byte(provCfg.ClientSecret)) + hashedSecret = base64.RawURLEncoding.EncodeToString(h.Sum(nil)) + h.Reset() if arn != DummyRoleARN { if res.Roles == nil { res.Roles = make(map[string]madmin.OpenIDProviderSettings)