2019-11-01 18:53:16 -04:00
|
|
|
/*
|
|
|
|
* MinIO Cloud Storage, (C) 2019 MinIO, Inc.
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package cmd
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"context"
|
2019-12-24 16:49:48 -05:00
|
|
|
"fmt"
|
2020-04-27 00:42:41 -04:00
|
|
|
"time"
|
2019-11-11 21:42:10 -05:00
|
|
|
"unicode/utf8"
|
2019-11-01 18:53:16 -04:00
|
|
|
|
|
|
|
"github.com/minio/minio/cmd/config"
|
|
|
|
"github.com/minio/minio/cmd/logger"
|
|
|
|
"github.com/minio/minio/pkg/auth"
|
|
|
|
"github.com/minio/minio/pkg/madmin"
|
2020-12-03 14:35:18 -05:00
|
|
|
etcd "go.etcd.io/etcd/clientv3"
|
2019-11-01 18:53:16 -04:00
|
|
|
)
|
|
|
|
|
2020-06-25 06:29:28 -04:00
|
|
|
func handleEncryptedConfigBackend(objAPI ObjectLayer) error {
|
2019-11-01 18:53:16 -04:00
|
|
|
|
2020-05-04 23:04:06 -04:00
|
|
|
encrypted, err := checkBackendEncrypted(objAPI)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("Unable to encrypt config %w", err)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
if encrypted {
|
|
|
|
// backend is encrypted, but credentials are not specified
|
|
|
|
// we shall fail right here. if not proceed forward.
|
|
|
|
if !globalConfigEncrypted || !globalActiveCred.IsValid() {
|
|
|
|
return config.ErrMissingCredentialsBackendEncrypted(nil)
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// backend is not yet encrypted, check if encryption of
|
|
|
|
// backend is requested if not return nil and proceed
|
|
|
|
// forward.
|
|
|
|
if !globalConfigEncrypted {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if !globalActiveCred.IsValid() {
|
2020-01-10 05:35:06 -05:00
|
|
|
return config.ErrMissingCredentialsBackendEncrypted(nil)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-05-04 23:04:06 -04:00
|
|
|
// Migrate IAM configuration
|
|
|
|
if err = migrateConfigPrefixToEncrypted(objAPI, globalOldCred, encrypted); err != nil {
|
|
|
|
return fmt.Errorf("Unable to migrate all config at .minio.sys/config/: %w", err)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
2020-05-04 23:04:06 -04:00
|
|
|
|
|
|
|
return nil
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
const (
|
|
|
|
backendEncryptedFile = "backend-encrypted"
|
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
2019-11-09 12:27:23 -05:00
|
|
|
backendEncryptedMigrationIncomplete = []byte("incomplete")
|
|
|
|
backendEncryptedMigrationComplete = []byte("encrypted")
|
2019-11-01 18:53:16 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
func checkBackendEtcdEncrypted(ctx context.Context, client *etcd.Client) (bool, error) {
|
|
|
|
data, err := readKeyEtcd(ctx, client, backendEncryptedFile)
|
|
|
|
if err != nil && err != errConfigNotFound {
|
|
|
|
return false, err
|
|
|
|
}
|
2019-11-09 12:27:23 -05:00
|
|
|
return err == nil && bytes.Equal(data, backendEncryptedMigrationComplete), nil
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
func checkBackendEncrypted(objAPI ObjectLayer) (bool, error) {
|
2020-04-09 12:30:02 -04:00
|
|
|
data, err := readConfig(GlobalContext, objAPI, backendEncryptedFile)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil && err != errConfigNotFound {
|
|
|
|
return false, err
|
|
|
|
}
|
2019-11-09 12:27:23 -05:00
|
|
|
return err == nil && bytes.Equal(data, backendEncryptedMigrationComplete), nil
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
2019-11-11 15:01:21 -05:00
|
|
|
// decryptData - decrypts input data with more that one credentials,
|
|
|
|
func decryptData(edata []byte, creds ...auth.Credentials) ([]byte, error) {
|
|
|
|
var err error
|
|
|
|
var data []byte
|
|
|
|
for _, cred := range creds {
|
|
|
|
data, err = madmin.DecryptData(cred.String(), bytes.NewReader(edata))
|
|
|
|
if err != nil {
|
|
|
|
if err == madmin.ErrMaliciousData {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
break
|
|
|
|
}
|
|
|
|
return data, err
|
|
|
|
}
|
|
|
|
|
2020-04-07 17:26:39 -04:00
|
|
|
func migrateIAMConfigsEtcdToEncrypted(ctx context.Context, client *etcd.Client) error {
|
2019-11-01 18:53:16 -04:00
|
|
|
encrypted, err := checkBackendEtcdEncrypted(ctx, client)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if encrypted {
|
|
|
|
// backend is encrypted, but credentials are not specified
|
|
|
|
// we shall fail right here. if not proceed forward.
|
|
|
|
if !globalConfigEncrypted || !globalActiveCred.IsValid() {
|
|
|
|
return config.ErrMissingCredentialsBackendEncrypted(nil)
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// backend is not yet encrypted, check if encryption of
|
|
|
|
// backend is requested if not return nil and proceed
|
|
|
|
// forward.
|
|
|
|
if !globalConfigEncrypted {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if !globalActiveCred.IsValid() {
|
|
|
|
return errInvalidArgument
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if encrypted {
|
|
|
|
// No key rotation requested, and backend is
|
|
|
|
// already encrypted. We proceed without migration.
|
2020-03-17 13:36:13 -04:00
|
|
|
if !globalOldCred.IsValid() {
|
2019-11-01 18:53:16 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// No real reason to rotate if old and new creds are same.
|
2020-03-17 13:36:13 -04:00
|
|
|
if globalOldCred.Equal(globalActiveCred) {
|
2019-11-01 18:53:16 -04:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-11-09 12:27:23 -05:00
|
|
|
logger.Info("Attempting rotation of encrypted IAM users and policies on etcd with newly supplied credentials")
|
2019-11-01 18:53:16 -04:00
|
|
|
} else {
|
2019-11-09 12:27:23 -05:00
|
|
|
logger.Info("Attempting encryption of all IAM users and policies on etcd")
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
2020-04-27 00:42:41 -04:00
|
|
|
listCtx, cancel := context.WithTimeout(ctx, 1*time.Minute)
|
|
|
|
defer cancel()
|
|
|
|
|
|
|
|
r, err := client.Get(listCtx, minioConfigPrefix, etcd.WithPrefix(), etcd.WithKeysOnly())
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2019-11-09 12:27:23 -05:00
|
|
|
|
|
|
|
if err = saveKeyEtcd(ctx, client, backendEncryptedFile, backendEncryptedMigrationIncomplete); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2019-11-01 18:53:16 -04:00
|
|
|
for _, kv := range r.Kvs {
|
|
|
|
var (
|
|
|
|
cdata []byte
|
|
|
|
cencdata []byte
|
|
|
|
)
|
|
|
|
cdata, err = readKeyEtcd(ctx, client, string(kv.Key))
|
|
|
|
if err != nil {
|
|
|
|
switch err {
|
|
|
|
case errConfigNotFound:
|
|
|
|
// Perhaps not present or someone deleted it.
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
2019-11-09 12:27:23 -05:00
|
|
|
|
|
|
|
var data []byte
|
2019-11-01 18:53:16 -04:00
|
|
|
// Is rotating of creds requested?
|
2020-03-17 13:36:13 -04:00
|
|
|
if globalOldCred.IsValid() {
|
|
|
|
data, err = decryptData(cdata, globalOldCred, globalActiveCred)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
if err == madmin.ErrMaliciousData {
|
2019-11-11 15:01:21 -05:00
|
|
|
return config.ErrInvalidRotatingCredentialsBackendEncrypted(nil)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
2019-11-11 15:01:21 -05:00
|
|
|
return err
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
2019-11-11 15:01:21 -05:00
|
|
|
} else {
|
|
|
|
data = cdata
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
2019-11-11 21:42:10 -05:00
|
|
|
if !utf8.Valid(data) {
|
2020-01-10 05:35:06 -05:00
|
|
|
_, err = decryptData(data, globalActiveCred)
|
|
|
|
if err == nil {
|
|
|
|
// Config is already encrypted with right keys
|
|
|
|
continue
|
|
|
|
}
|
2020-10-28 03:09:15 -04:00
|
|
|
return fmt.Errorf("Decrypting config failed %w, possibly credentials are incorrect", err)
|
2019-11-09 12:27:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
cencdata, err = madmin.EncryptData(globalActiveCred.String(), data)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if err = saveKeyEtcd(ctx, client, string(kv.Key), cencdata); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
2020-01-10 05:35:06 -05:00
|
|
|
|
2020-03-17 13:36:13 -04:00
|
|
|
if encrypted && globalActiveCred.IsValid() && globalOldCred.IsValid() {
|
2019-11-09 12:27:23 -05:00
|
|
|
logger.Info("Rotation complete, please make sure to unset MINIO_ACCESS_KEY_OLD and MINIO_SECRET_KEY_OLD envs")
|
|
|
|
}
|
2020-01-10 05:35:06 -05:00
|
|
|
|
2019-11-09 12:27:23 -05:00
|
|
|
return saveKeyEtcd(ctx, client, backendEncryptedFile, backendEncryptedMigrationComplete)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
func migrateConfigPrefixToEncrypted(objAPI ObjectLayer, activeCredOld auth.Credentials, encrypted bool) error {
|
|
|
|
if encrypted {
|
|
|
|
// No key rotation requested, and backend is
|
|
|
|
// already encrypted. We proceed without migration.
|
|
|
|
if !activeCredOld.IsValid() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// No real reason to rotate if old and new creds are same.
|
|
|
|
if activeCredOld.Equal(globalActiveCred) {
|
|
|
|
return nil
|
|
|
|
}
|
2019-11-09 12:27:23 -05:00
|
|
|
logger.Info("Attempting rotation of encrypted config, IAM users and policies on MinIO with newly supplied credentials")
|
|
|
|
} else {
|
|
|
|
logger.Info("Attempting encryption of all config, IAM users and policies on MinIO backend")
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
2020-04-09 12:30:02 -04:00
|
|
|
err := saveConfig(GlobalContext, objAPI, backendEncryptedFile, backendEncryptedMigrationIncomplete)
|
2019-11-09 12:27:23 -05:00
|
|
|
if err != nil {
|
|
|
|
return err
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
var marker string
|
|
|
|
for {
|
2020-04-09 12:30:02 -04:00
|
|
|
res, err := objAPI.ListObjects(GlobalContext, minioMetaBucket,
|
2020-01-10 05:35:06 -05:00
|
|
|
minioConfigPrefix, marker, "", maxObjectList)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
for _, obj := range res.Objects {
|
|
|
|
var (
|
|
|
|
cdata []byte
|
|
|
|
cencdata []byte
|
|
|
|
)
|
|
|
|
|
2020-04-09 12:30:02 -04:00
|
|
|
cdata, err = readConfig(GlobalContext, objAPI, obj.Name)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2019-11-09 12:27:23 -05:00
|
|
|
var data []byte
|
2019-11-01 18:53:16 -04:00
|
|
|
// Is rotating of creds requested?
|
|
|
|
if activeCredOld.IsValid() {
|
2019-11-11 15:01:21 -05:00
|
|
|
data, err = decryptData(cdata, activeCredOld, globalActiveCred)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
if err == madmin.ErrMaliciousData {
|
2019-11-11 15:01:21 -05:00
|
|
|
return config.ErrInvalidRotatingCredentialsBackendEncrypted(nil)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
2019-11-11 15:01:21 -05:00
|
|
|
return err
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
2019-11-11 15:01:21 -05:00
|
|
|
} else {
|
|
|
|
data = cdata
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|
|
|
|
|
2019-11-11 21:42:10 -05:00
|
|
|
if !utf8.Valid(data) {
|
2020-01-10 05:35:06 -05:00
|
|
|
_, err = decryptData(data, globalActiveCred)
|
|
|
|
if err == nil {
|
|
|
|
// Config is already encrypted with right keys
|
|
|
|
continue
|
|
|
|
}
|
2020-10-28 03:09:15 -04:00
|
|
|
return fmt.Errorf("Decrypting config failed %w, possibly credentials are incorrect", err)
|
2019-11-09 12:27:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
cencdata, err = madmin.EncryptData(globalActiveCred.String(), data)
|
2019-11-01 18:53:16 -04:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2020-04-09 12:30:02 -04:00
|
|
|
if err = saveConfig(GlobalContext, objAPI, obj.Name, cencdata); err != nil {
|
2019-11-01 18:53:16 -04:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if !res.IsTruncated {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
|
|
|
marker = res.NextMarker
|
|
|
|
}
|
|
|
|
|
2020-01-10 05:35:06 -05:00
|
|
|
if encrypted && globalActiveCred.IsValid() && activeCredOld.IsValid() {
|
2019-11-09 12:27:23 -05:00
|
|
|
logger.Info("Rotation complete, please make sure to unset MINIO_ACCESS_KEY_OLD and MINIO_SECRET_KEY_OLD envs")
|
|
|
|
}
|
|
|
|
|
2020-04-09 12:30:02 -04:00
|
|
|
return saveConfig(GlobalContext, objAPI, backendEncryptedFile, backendEncryptedMigrationComplete)
|
2019-11-01 18:53:16 -04:00
|
|
|
}
|