From 772541afaba27716e3b5bd2a861a993f347dbfbd Mon Sep 17 00:00:00 2001 From: Kristoffer Dalby Date: Mon, 4 Oct 2021 14:16:37 +0100 Subject: [PATCH] add comment about poor error handling when headscale isnt becoming available --- integration_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/integration_test.go b/integration_test.go index ecde3830..7e75089d 100644 --- a/integration_test.go +++ b/integration_test.go @@ -258,7 +258,11 @@ func (s *IntegrationTestSuite) SetupSuite() { } return nil }); err != nil { - log.Fatalf("Could not connect to docker: %s", err) + // TODO(kradalby): If we cannot access headscale, or any other fatal error during + // test setup, we need to abort and tear down. However, testify does not seem to + // support that at the moment: + // https://github.com/stretchr/testify/issues/849 + return // fmt.Errorf("Could not connect to headscale: %s", err) } fmt.Println("headscale container is ready")