mirror of
https://github.com/ventoy/Ventoy.git
synced 2025-01-05 12:03:24 -05:00
9789069c0d
Dear Ventoy community –
Our team is working with your code and we noticed this if logical expression:
if (len - 1 - (int)(long)(pos - pwdstr) != 32)
We studied the surrounding code. We believe we understand the intention of the type casts in the above if statement. It seems they were meant to ensure an underflow doesn’t occur by the subtraction between to char pointers, which is a great catch (!). However, we believe the way the type casts are structured, the code is not actually protecting against such underflow because pwdstr isn’t cast into a signed long until after the subtraction occurs. To properly protect this code against underflow, we believe it should be changed to something like the following:
if (len - 1 - ((long)pos – (long)pwdstr) != 32)
Or, to enhance readability for junior engineers who may not know that the “long” type cast is implicitly of a signed integer type, we could include the `signed` keyword for added verbosity:
if (len - 1 - ((signed long)pos – (signed long)pwdstr) != 32)
Thank you!
|
||
|---|---|---|
| .. | ||
| boot/i386/pc | ||
| commands | ||
| disk | ||
| font | ||
| fs | ||
| gfxmenu | ||
| kern | ||
| lib | ||
| loader | ||
| normal | ||
| partmap | ||
| script | ||
| term | ||
| ventoy | ||
| Makefile.am | ||
| Makefile.core.def | ||