MyFavMirrors/MeshCentral
1
0
Fork 0
mirror of https://github.com/Ylianst/MeshCentral.git synced 2025-03-31 09:43:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed #5378, in some cases MPS crash when reverse lookup of IPv6 address.

Browse Source
This commit is contained in:
Ylian Saint-Hilaire 2023-10-02 00:30:16 -07:00
parent 9fc7fd2c5a
commit b99fb68675
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mpsserver.js
View File

@ -733,7 +733,7 @@ module.exports.CreateMpsServer = function (parent, db, args, certificates) {
return; return;
} else { } else {
// Attempts reverse DNS loopup on the device IP address // Attempts reverse DNS loopup on the device IP address
require('dns').reverse(socket.remoteAddr, function (err, hostnames) { const reverseDnsLookupHandler = function (err, hostnames) {
var hostname = socket.remoteAddr; var hostname = socket.remoteAddr;
if ((err == null) && (hostnames != null) && (hostnames.length > 0)) { hostname = hostnames[0]; } if ((err == null) && (hostnames != null) && (hostnames.length > 0)) { hostname = hostnames[0]; }
@ -752,7 +752,8 @@ module.exports.CreateMpsServer = function (parent, db, args, certificates) {
addedDeviceCount++; addedDeviceCount++;
var change = 'Added CIRA device ' + socket.tag.name + ' to group ' + initialMesh.name; var change = 'Added CIRA device ' + socket.tag.name + ' to group ' + initialMesh.name;
obj.parent.DispatchEvent(['*', socket.tag.meshid], obj, { etype: 'node', action: 'addnode', node: parent.webserver.CloneSafeNode(device), msg: change, domain: initialMesh.domain }); obj.parent.DispatchEvent(['*', socket.tag.meshid], obj, { etype: 'node', action: 'addnode', node: parent.webserver.CloneSafeNode(device), msg: change, domain: initialMesh.domain });
}); }
try { require('dns').reverse(socket.remoteAddr, reverseDnsLookupHandler); } catch (ex) { reverseDnsLookupHandler(ex, null); }
} }
} else { } else {
// Node is already present // Node is already present