From b7512b9bedb8ee9a3739c3ed8eeea21c7f139f74 Mon Sep 17 00:00:00 2001 From: Daan Date: Sun, 13 Apr 2025 11:59:34 +0200 Subject: [PATCH] Disable dynamic config feature by default. --- docker/Dockerfile | 2 +- docker/README.md | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docker/Dockerfile b/docker/Dockerfile index bda5cb9f..7d816f57 100644 --- a/docker/Dockerfile +++ b/docker/Dockerfile @@ -41,7 +41,7 @@ FROM alpine:3.21 # environment variables ENV NODE_ENV="production" \ CONFIG_FILE="/opt/meshcentral/meshcentral-data/config.json" \ - DYNAMIC_CONFIG="true" + DYNAMIC_CONFIG="false" # environment variables for the above defined MeshCentral Config.json ENV ALLOW_PLUGINS="false" \ diff --git a/docker/README.md b/docker/README.md index 9eecac95..c0e66f8d 100644 --- a/docker/README.md +++ b/docker/README.md @@ -1,5 +1,10 @@ # MeshCentral Docker Configuration Guide +> [!NOTE] +> Out of precaution, DYNAMIC_CONFIG has been disabled by default.
+> The reason why is because when its enabled and a working config without corresponding environment variables gives,
+> Then the container will overwrite it to a incorrect, but working state - perhaps non-working for your environment. + ## Overview This document provides a comprehensive guide to setting up and configuring MeshCentral in a Docker environment. It includes available options, security measures, and deployment instructions. @@ -11,7 +16,7 @@ Below is a breakdown of environment variables used in this setup. |----------|--------------|-------------| | NODE_ENV | production | Specifies the Node.js environment. | | CONFIG_FILE | /opt/meshcentral/meshcentral-data/config.json | Path to the configuration file. | -| DYNAMIC_CONFIG | true | Enables/disables dynamic configuration. This means config is being rechecked every container restart. | +| DYNAMIC_CONFIG | false | Enables/disables dynamic configuration. This means config is being rechecked every container restart. False if you want to use your own `config.json` | | ALLOW_PLUGINS | false | Enables/disables plugins. | | ALLOW_NEW_ACCOUNTS | false | Enables/disables new account creation. | | ALLOWED_ORIGIN | false | Enables/disables allowed origin policy. |